thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(locators): do not retry via catchError (#10762)

Browse Source
This commit is contained in:
Alex Rudenko 2023-08-21 18:32:13 +02:00 committed by GitHub
parent bb944ad968
commit 8f9388f2ce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
packages/puppeteer-core/src/api/locators/Locator.ts
View File

@ -442,9 +442,9 @@ export abstract class Locator<T> extends EventEmitter {
}), }),
mergeMap(handle => { mergeMap(handle => {
return from(handle.click(options)).pipe( return from(handle.click(options)).pipe(
catchError((_, caught) => { catchError(err => {
void handle.dispose().catch(debugError); void handle.dispose().catch(debugError);
return caught; throw err;
}) })
); );
}), }),
@ -575,9 +575,9 @@ export abstract class Locator<T> extends EventEmitter {
}) })
) )
.pipe( .pipe(
catchError((_, caught) => { catchError(err => {
void handle.dispose().catch(debugError); void handle.dispose().catch(debugError);
return caught; throw err;
}) })
); );
}), }),
@ -603,9 +603,9 @@ export abstract class Locator<T> extends EventEmitter {
}), }),
mergeMap(handle => { mergeMap(handle => {
return from(handle.hover()).pipe( return from(handle.hover()).pipe(
catchError((_, caught) => { catchError(err => {
void handle.dispose().catch(debugError); void handle.dispose().catch(debugError);
return caught; throw err;
}) })
); );
}), }),
@ -644,9 +644,9 @@ export abstract class Locator<T> extends EventEmitter {
options?.scrollLeft options?.scrollLeft
) )
).pipe( ).pipe(
catchError((_, caught) => { catchError(err => {
void handle.dispose().catch(debugError); void handle.dispose().catch(debugError);
return caught; throw err;
}) })
); );
}), }),