thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(testreporter): Test Reporter should not terminate node.js process (#4716)

Browse Source 
This patch starts assigning process exit codes rather than terminating
parent process. Library should never own/terminate parent node.js
process.
This commit is contained in:
Andrey Lushnikov 2019-07-16 16:34:41 -07:00 committed by GitHub
parent eea55bd6c6
commit 934d73e526
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
utils/testrunner/Reporter.js
View File

@ -80,13 +80,13 @@ class Reporter {
description = `${RED_COLOR}<UNKNOWN>${RESET_COLOR}`; description = `${RED_COLOR}<UNKNOWN>${RESET_COLOR}`;
console.log(` ${workerId}: [${description}] ${test.fullName} (${formatTestLocation(test)})`); console.log(` ${workerId}: [${description}] ${test.fullName} (${formatTestLocation(test)})`);
} }
process.exit(2); process.exitCode = 2;
} }
_onFinished() { _onFinished() {
this._printTestResults(); this._printTestResults();
const failedTests = this._runner.failedTests(); const failedTests = this._runner.failedTests();
process.exit(failedTests.length > 0 ? 1 : 0); process.exitCode = failedTests.length > 0 ? 1 : 0;
} }
_printTestResults() { _printTestResults() {