diff --git a/experimental/puppeteer-firefox/package.json b/experimental/puppeteer-firefox/package.json index 617f4e23..b91f033d 100644 --- a/experimental/puppeteer-firefox/package.json +++ b/experimental/puppeteer-firefox/package.json @@ -9,7 +9,7 @@ "node": ">=8.9.4" }, "puppeteer": { - "firefox_revision": "c74102def6c16584c155a98741e8143ab5d615b9" + "firefox_revision": "10282bfac697c69a6fdfeec4cddae7caf98e1969" }, "scripts": { "install": "node install.js", diff --git a/test/launcher.spec.js b/test/launcher.spec.js index f21fdf69..1342b978 100644 --- a/test/launcher.spec.js +++ b/test/launcher.spec.js @@ -314,6 +314,16 @@ module.exports.addTests = function({testRunner, expect, defaultBrowserOptions, p expect(await secondPage.evaluate(() => 7 * 6)).toBe(42, 'original browser should still work'); await originalBrowser.close(); }); + it('should be able to close remote browser', async({server}) => { + const originalBrowser = await puppeteer.launch(defaultBrowserOptions); + const remoteBrowser = await puppeteer.connect({ + browserWSEndpoint: originalBrowser.wsEndpoint() + }); + await Promise.all([ + utils.waitEvent(originalBrowser, 'disconnected'), + remoteBrowser.close(), + ]); + }); it('should support ignoreHTTPSErrors option', async({httpsServer}) => { const originalBrowser = await puppeteer.launch(defaultBrowserOptions); const browserWSEndpoint = originalBrowser.wsEndpoint();