From 9d310682259da539199774b4a7ccc1b37b548b5c Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Mon, 8 Apr 2019 12:11:35 -0700 Subject: [PATCH] feat(chromium): roll Chromium to r648643 (#4256) This roll includes: - https://crrev.com/648335 - [DevTools] Send DevTools request ID through URLLoader - https://crrev.com/648360 - [DevTools] Add renderer request ID to requestIntercepted References #3471 --- lib/Launcher.js | 2 ++ package.json | 2 +- test/page.spec.js | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/Launcher.js b/lib/Launcher.js index c860956e..e311067d 100644 --- a/lib/Launcher.js +++ b/lib/Launcher.js @@ -49,6 +49,8 @@ const DEFAULT_ARGS = [ '--disable-features=site-per-process,TranslateUI,BlinkGenPropertyTrees', '--disable-hang-monitor', '--disable-ipc-flooding-protection', + // TODO: Perfetto is disabled due to crbug.com/950620 + '--disable-perfetto', '--disable-popup-blocking', '--disable-prompt-on-repost', '--disable-renderer-backgrounding', diff --git a/package.json b/package.json index ae667e7a..2e1db35f 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,7 @@ "node": ">=6.4.0" }, "puppeteer": { - "chromium_revision": "647475" + "chromium_revision": "648643" }, "scripts": { "unit": "node test/test.js", diff --git a/test/page.spec.js b/test/page.spec.js index 9061b758..074ef73d 100644 --- a/test/page.spec.js +++ b/test/page.spec.js @@ -366,6 +366,8 @@ module.exports.addTests = function({testRunner, expect, headless, Errors, Device expect(message.type()).toEqual('warn'); }); it_fails_ffox('should have location when fetch fails', async({page, server}) => { + // The point of this test is to make sure that we report console messages from + // Log domain: https://vanilla.aslushnikov.com/?Log.entryAdded await page.goto(server.EMPTY_PAGE); const [message] = await Promise.all([ waitEvent(page, 'console'),