From 9faecc2e67fe9baf8749a6f63a876864384e207f Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Wed, 5 Jul 2017 18:09:17 -0700 Subject: [PATCH] Fix Page.setContent method The patch fixes an unfortunate bug in Page.setContent method and adds a test to cover it. References #50. --- lib/Page.js | 2 +- test/test.js | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/Page.js b/lib/Page.js index 31fa78d6..eb06dfa0 100644 --- a/lib/Page.js +++ b/lib/Page.js @@ -248,7 +248,7 @@ class Page extends EventEmitter { * @return {!Promise} */ async setContent(html) { - this.evaluate(() => { + this.evaluate((html) => { document.open(); document.write(html); document.close(); diff --git a/test/test.js b/test/test.js index 8017e1f5..a1497653 100644 --- a/test/test.js +++ b/test/test.js @@ -497,6 +497,13 @@ describe('Puppeteer', function() { expect(request.headers['foo']).toBe('bar'); })); }); + describe('Page.setContent', function() { + it('should work', SX(async function() { + await page.setContent('
hello
'); + let result = await page.evaluate(() => document.body.innerHTML); + expect(result).toBe('
hello
'); + })); + }); describe('Network Events', function() { it('Page.Events.Request', SX(async function() { let requests = [];