thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(helper): fix Helper.installAsyncStackHooks method (#4478)

Browse Source 
Using Error.captureStackTrace instead of new Error () to avoid UnhandledPromiseRejectionWarning
This commit is contained in:
Adriel Codeco 2019-05-31 23:39:32 -03:00 committed by Andrey Lushnikov
parent d221c02c13
commit ac611bacac
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
experimental/puppeteer-firefox/lib/helper.js
View File

@ -28,7 +28,8 @@ class Helper {
if (methodName === 'constructor' || typeof methodName !== 'string' || methodName.startsWith('_') || typeof method !== 'function' || method.constructor.name !== 'AsyncFunction') if (methodName === 'constructor' || typeof methodName !== 'string' || methodName.startsWith('_') || typeof method !== 'function' || method.constructor.name !== 'AsyncFunction')
continue; continue;
Reflect.set(classType.prototype, methodName, function(...args) { Reflect.set(classType.prototype, methodName, function(...args) {
const syncStack = new Error(); const syncStack = {};
Error.captureStackTrace(syncStack);
return method.call(this, ...args).catch(e => { return method.call(this, ...args).catch(e => {
const stack = syncStack.stack.substring(syncStack.stack.indexOf('\n') + 1); const stack = syncStack.stack.substring(syncStack.stack.indexOf('\n') + 1);
const clientStack = stack.substring(stack.indexOf('\n')); const clientStack = stack.substring(stack.indexOf('\n'));

3
lib/helper.js
View File

@ -107,7 +107,8 @@ class Helper {
if (methodName === 'constructor' || typeof methodName !== 'string' || methodName.startsWith('_') || typeof method !== 'function' || method.constructor.name !== 'AsyncFunction') if (methodName === 'constructor' || typeof methodName !== 'string' || methodName.startsWith('_') || typeof method !== 'function' || method.constructor.name !== 'AsyncFunction')
continue; continue;
Reflect.set(classType.prototype, methodName, function(...args) { Reflect.set(classType.prototype, methodName, function(...args) {
const syncStack = new Error(); const syncStack = {};
Error.captureStackTrace(syncStack);
return method.call(this, ...args).catch(e => { return method.call(this, ...args).catch(e => {
const stack = syncStack.stack.substring(syncStack.stack.indexOf('\n') + 1); const stack = syncStack.stack.substring(syncStack.stack.indexOf('\n') + 1);
const clientStack = stack.substring(stack.indexOf('\n')); const clientStack = stack.substring(stack.indexOf('\n'));