diff --git a/scripts/test-ts-definition-files.ts b/scripts/test-ts-definition-files.ts index 3ee8a331..e65fbfa0 100644 --- a/scripts/test-ts-definition-files.ts +++ b/scripts/test-ts-definition-files.ts @@ -34,7 +34,7 @@ const EXPECTED_ERRORS = new Map([ "bad.js(5,35): error TS2551: Property 'launh' does not exist on type", "bad.js(7,29): error TS2551: Property 'devics' does not exist on type", 'bad.js(11,39): error TS2554: Expected 0 arguments, but got 1.', - "bad.js(15,9): error TS2322: Type 'ElementHandle | null' is not assignable to type 'ElementHandle'", + "bad.js(15,9): error TS2322: Type 'ElementHandle | null' is not assignable to type 'ElementHandle'", ], ], [ @@ -43,7 +43,7 @@ const EXPECTED_ERRORS = new Map([ "bad.js(5,35): error TS2551: Property 'launh' does not exist on type", "bad.js(7,29): error TS2551: Property 'devics' does not exist on type", 'bad.js(11,39): error TS2554: Expected 0 arguments, but got 1.', - "bad.js(15,9): error TS2322: Type 'ElementHandle | null' is not assignable to type 'ElementHandle'", + "bad.js(15,9): error TS2322: Type 'ElementHandle | null' is not assignable to type 'ElementHandle'", ], ], [ @@ -52,7 +52,7 @@ const EXPECTED_ERRORS = new Map([ "bad.js(5,35): error TS2551: Property 'launh' does not exist on type", "bad.js(7,29): error TS2551: Property 'devics' does not exist on type", 'bad.js(11,39): error TS2554: Expected 0 arguments, but got 1.', - "bad.js(15,9): error TS2322: Type 'ElementHandle | null' is not assignable to type 'ElementHandle'", + "bad.js(15,9): error TS2322: Type 'ElementHandle | null' is not assignable to type 'ElementHandle'", ], ], [ @@ -61,7 +61,7 @@ const EXPECTED_ERRORS = new Map([ "bad.js(5,35): error TS2551: Property 'launh' does not exist on type", "bad.js(7,29): error TS2551: Property 'devics' does not exist on type", 'bad.js(11,39): error TS2554: Expected 0 arguments, but got 1.', - "bad.js(15,9): error TS2322: Type 'ElementHandle | null' is not assignable to type 'ElementHandle'", + "bad.js(15,9): error TS2322: Type 'ElementHandle | null' is not assignable to type 'ElementHandle'", ], ], ]); diff --git a/src/common/DOMWorld.ts b/src/common/DOMWorld.ts index 829c574b..7906d131 100644 --- a/src/common/DOMWorld.ts +++ b/src/common/DOMWorld.ts @@ -166,9 +166,11 @@ export class DOMWorld { ); } - async $(selector: string): Promise { + async $( + selector: string + ): Promise | null> { const document = await this._document(); - const value = await document.$(selector); + const value = await document.$(selector); return value; } @@ -216,9 +218,11 @@ export class DOMWorld { return value; } - async $$(selector: string): Promise { + async $$( + selector: string + ): Promise>> { const document = await this._document(); - const value = await document.$$(selector); + const value = await document.$$(selector); return value; } diff --git a/src/common/FrameManager.ts b/src/common/FrameManager.ts index df993c9b..02d76a68 100644 --- a/src/common/FrameManager.ts +++ b/src/common/FrameManager.ts @@ -722,8 +722,10 @@ export class Frame { * @returns A promise which resolves to an `ElementHandle` pointing at the * element, or `null` if it was not found. */ - async $(selector: string): Promise { - return this._mainWorld.$(selector); + async $( + selector: string + ): Promise | null> { + return this._mainWorld.$(selector); } /** @@ -801,8 +803,10 @@ export class Frame { * @param selector - a selector to search for * @returns An array of element handles pointing to the found frame elements. */ - async $$(selector: string): Promise { - return this._mainWorld.$$(selector); + async $$( + selector: string + ): Promise>> { + return this._mainWorld.$$(selector); } /** diff --git a/src/common/JSHandle.ts b/src/common/JSHandle.ts index cbe97e1f..9cbd4654 100644 --- a/src/common/JSHandle.ts +++ b/src/common/JSHandle.ts @@ -771,7 +771,9 @@ export class ElementHandle< * Runs `element.querySelector` within the page. If no element matches the selector, * the return value resolves to `null`. */ - async $(selector: string): Promise { + async $( + selector: string + ): Promise | null> { const { updatedSelector, queryHandler } = getQueryHandlerAndSelector( selector ); @@ -782,7 +784,9 @@ export class ElementHandle< * Runs `element.querySelectorAll` within the page. If no elements match the selector, * the return value resolves to `[]`. */ - async $$(selector: string): Promise { + async $$( + selector: string + ): Promise>> { const { updatedSelector, queryHandler } = getQueryHandlerAndSelector( selector ); diff --git a/src/common/Page.ts b/src/common/Page.ts index db30be48..508da234 100644 --- a/src/common/Page.ts +++ b/src/common/Page.ts @@ -830,8 +830,10 @@ export class Page extends EventEmitter { * {@link https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Selectors | selector} * to query page for. */ - async $(selector: string): Promise { - return this.mainFrame().$(selector); + async $( + selector: string + ): Promise | null> { + return this.mainFrame().$(selector); } /** @@ -1074,8 +1076,10 @@ export class Page extends EventEmitter { return this.mainFrame().$$eval(selector, pageFunction, ...args); } - async $$(selector: string): Promise { - return this.mainFrame().$$(selector); + async $$( + selector: string + ): Promise>> { + return this.mainFrame().$$(selector); } async $x(expression: string): Promise { diff --git a/test/accessibility.spec.ts b/test/accessibility.spec.ts index e941c683..605915b8 100644 --- a/test/accessibility.spec.ts +++ b/test/accessibility.spec.ts @@ -434,7 +434,7 @@ describeFailsFirefox('Accessibility', function () { await page.setContent(``); - const button = await page.$('button'); + const button = await page.$('button'); expect(await page.accessibility.snapshot({ root: button })).toEqual({ role: 'button', name: 'My Button', diff --git a/test/ariaqueryhandler.spec.ts b/test/ariaqueryhandler.spec.ts index 026047fc..f38e7e76 100644 --- a/test/ariaqueryhandler.spec.ts +++ b/test/ariaqueryhandler.spec.ts @@ -571,7 +571,7 @@ describeChromeOnly('AriaQueryHandler', () => { }); it('should find by role "button"', async () => { const { page } = getTestState(); - const found = await page.$$('aria/[role="button"]'); + const found = await page.$$('aria/[role="button"]'); const ids = await getIds(found); expect(ids).toEqual(['node5', 'node6', 'node8', 'node10', 'node21']); });