thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: fix typings for ElementHandle.screenshot() options (#7602)

Browse Source
This commit is contained in:
s 2021-09-29 11:46:57 -04:00 committed by GitHub
parent a271145b06
commit b4ba9c803d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/common/JSHandle.ts
View File

@ -17,7 +17,7 @@
import { assert } from './assert.js'; import { assert } from './assert.js';
import { helper, debugError } from './helper.js'; import { helper, debugError } from './helper.js';
import { ExecutionContext } from './ExecutionContext.js'; import { ExecutionContext } from './ExecutionContext.js';
import { Page } from './Page.js'; import { Page, ScreenshotOptions } from './Page.js';
import { CDPSession } from './Connection.js'; import { CDPSession } from './Connection.js';
import { KeyInput } from './USKeyboardLayout.js'; import { KeyInput } from './USKeyboardLayout.js';
import { FrameManager, Frame } from './FrameManager.js'; import { FrameManager, Frame } from './FrameManager.js';
@ -813,7 +813,7 @@ export class ElementHandle<
* {@link Page.screenshot} to take a screenshot of the element. * {@link Page.screenshot} to take a screenshot of the element.
* If the element is detached from DOM, the method throws an error. * If the element is detached from DOM, the method throws an error.
*/ */
async screenshot(options = {}): Promise<string | Buffer> { async screenshot(options: ScreenshotOptions = {}): Promise<string | Buffer> {
let needsViewportReset = false; let needsViewportReset = false;
let boundingBox = await this.boundingBox(); let boundingBox = await this.boundingBox();

7
utils/doclint/check_public_api/index.js
View File

@ -428,6 +428,13 @@ function compareDocumentations(actual, expected) {
expectedName: 'DragData', expectedName: 'DragData',
}, },
], ],
[
'Method ElementHandle.screenshot() options',
{
actualName: 'Object',
expectedName: 'ScreenshotOptions',
},
],
[ [
'Method Keyboard.down() key', 'Method Keyboard.down() key',
{ {