thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(launcher): launch browser with 'about:blank' by default (#2594)

Browse Source 
fixes #2402
This commit is contained in:
Yaniv Efraim 2018-05-26 03:26:40 +03:00 committed by Andrey Lushnikov
parent 1e07925e26
commit b8df8bdf4a
2 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Launcher.js
View File

@ -93,6 +93,9 @@ class Launcher {
'--mute-audio'
);
}
if (!options.ignoreDefaultArgs && Array.isArray(options.args) && options.args.every(arg => arg.startsWith('-')))
chromeArguments.push('about:blank');
let chromeExecutable = options.executablePath;
if (typeof chromeExecutable !== 'string') {
const browserFetcher = new BrowserFetcher();

22
test/puppeteer.spec.js
View File

@ -264,6 +264,28 @@ module.exports.addTests = function({testRunner, expect, PROJECT_ROOT, defaultBro
await page.close();
await browser.close();
});
it('should have default url when launching browser', async function() {
const browser = await puppeteer.launch(defaultBrowserOptions);
const pages = (await browser.pages()).map(page => page.url());
expect(pages).toEqual(['about:blank']);
await browser.close();
});
it('should have default url when launching browser with headless:false', async function() {
const options = Object.assign({}, defaultBrowserOptions, {headless: false});
const browser = await puppeteer.launch(options);
const pages = (await browser.pages()).map(page => page.url());
expect(pages).toEqual(['about:blank']);
await browser.close();
});
it('should have custom url when launching browser', async function({server}) {
const customUrl = server.PREFIX + '/empty.html';
const options = Object.assign({}, defaultBrowserOptions);
options.args = [customUrl].concat(options.args);
const browser = await puppeteer.launch(options);
const pages = (await browser.pages()).map(page => page.url());
expect(pages).toEqual([customUrl]);
await browser.close();
});
});
describe('Puppeteer.connect', function() {
it('should be able to connect multiple times to the same browser', async({server}) => {