thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: generate testIds on CIs only (#4817)

Browse Source
This commit is contained in:
Andrey Lushnikov 2019-08-07 10:26:53 -07:00 committed by GitHub
parent 656fe46047
commit c047624b68
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/utils.js
View File

@ -165,9 +165,9 @@ const utils = module.exports = {
// Generate testIDs for all tests and verify they don't clash.
// This will add |test.testId| for every test.
//
// NOTE: we do this unconditionally so that developers can see problems in
// their local setups.
generateTestIDs(testRunner);
// NOTE: we do this on CI's so that problems arise on PR trybots.
if (process.env.CI)
generateTestIDs(testRunner);
// FLAKINESS_DASHBOARD_PASSWORD is an encrypted/secured variable.
// Encrypted variables get a special treatment in CI's when handling PRs so that
// secrets are not leaked to untrusted code.