thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: resolve navigation requests when request fails (#9178)

Browse Source 
#8768 fixes flakiness in handling navigations but it didn't account for
the fact that subsequent navigation requests could be aborted via the
request interception. In that case, the navigationResponseReceived
promise would never be resolved. This PR adds a listener for the failed
network requests and resolves the promise if the network request has
failed. Adding test coverage for this seems tricky, as the reproduction
depends on timing of the second navigation request.

Closes #9175
This commit is contained in:
Alex Rudenko 2022-10-28 09:56:06 +02:00 committed by GitHub
parent 2d2120cea1
commit c11297baa5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/puppeteer-core/src/common/LifecycleWatcher.ts
View File

@ -168,6 +168,11 @@ export class LifecycleWatcher {
NetworkManagerEmittedEvents.Response, NetworkManagerEmittedEvents.Response,
this.#onResponse.bind(this) this.#onResponse.bind(this)
), ),
addEventListener(
this.#frameManager.networkManager,
NetworkManagerEmittedEvents.RequestFailed,
this.#onRequestFailed.bind(this)
),
]; ];
this.#timeoutPromise = this.#createTimeoutPromise(); this.#timeoutPromise = this.#createTimeoutPromise();
@ -189,6 +194,13 @@ export class LifecycleWatcher {
} }
} }
#onRequestFailed(request: HTTPRequest): void {
if (this.#navigationRequest?._requestId !== request._requestId) {
return;
}
this.#navigationResponseReceived?.resolve();
}
#onResponse(response: HTTPResponse): void { #onResponse(response: HTTPResponse): void {
if (this.#navigationRequest?._requestId !== response.request()._requestId) { if (this.#navigationRequest?._requestId !== response.request()._requestId) {
return; return;