fix: correctly parse the default buildId (#10535)

2023-07-11 09:38:17 +02:00 · 2023-07-11 09:38:17 +02:00 · c308266111
commit c308266111
parent 19111be8d0
2 changed files with 12 additions and 1 deletions
--- a/packages/browsers/src/CLI.ts
+++ b/packages/browsers/src/CLI.ts
@ -274,7 +274,8 @@ export class CLI {
  }

  #parseBuildId(version: string): string {
-    return version.split('@').pop() ?? 'latest';
+    const parts = version.split('@');
+    return parts.length === 2 ? parts[1]! : 'latest';
  }
 }

--- a/packages/browsers/test/src/firefox/cli.spec.ts
+++ b/packages/browsers/test/src/firefox/cli.spec.ts
@ -75,5 +75,15 @@ describe('Firefox CLI', function () {
      '--platform=linux',
      `--base-url=${getServerUrl()}`,
    ]);
+
+    await new CLI(tmpDir).run([
+      'npx',
+      '@puppeteer/browsers',
+      'install',
+      `firefox`,
+      `--path=${tmpDir}`,
+      '--platform=linux',
+      `--base-url=${getServerUrl()}`,
+    ]);
  });
 });