From c32df08e4cff4884854eb452070042816f39cd9f Mon Sep 17 00:00:00 2001 From: JoelEinbinder Date: Wed, 2 Aug 2017 15:02:41 -0700 Subject: [PATCH] Update jsdoc from Tracing patch (#189) This fixes the comments @a1ph on #181 about JSDOC. --- lib/Tracing.js | 4 +++- test/test.js | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/Tracing.js b/lib/Tracing.js index 9d55e752..f82b319d 100644 --- a/lib/Tracing.js +++ b/lib/Tracing.js @@ -27,6 +27,7 @@ class Tracing { /** * @param {Object=} options + * @return {!Promise} */ async start(options = {}) { console.assert(!this._recording, 'Cannot start recording trace while already recording trace.'); @@ -50,6 +51,7 @@ class Tracing { /** * @param {string} path + * @return {!Promise} */ async stop(path) { let fulfill; @@ -64,7 +66,7 @@ class Tracing { /** * @param {string} handle - * @param {string=} path + * @param {string} path * @return {!Promise} */ async _readStream(handle, path) { diff --git a/test/test.js b/test/test.js index f1dc8fbb..b8e9f0b2 100644 --- a/test/test.js +++ b/test/test.js @@ -1361,7 +1361,7 @@ describe('Page', function() { }); describe('Page.pdf', function() { - let outputFile = __dirname + '/assets/output.pdf'; + const outputFile = __dirname + '/assets/output.pdf'; afterEach(function() { fs.unlinkSync(outputFile); });