thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix launcher to not leak event listeners (#605)

Browse Source 
This patch fixes launcher to not leak event listeners.
This commit is contained in:
Andrey Lushnikov 2017-08-29 22:49:50 -07:00 committed by GitHub
parent 11ce8b249f
commit c9b0a6c060
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/Launcher.js
View File

@ -85,13 +85,12 @@ class Launcher {
} }
// Cleanup as processes exit. // Cleanup as processes exit.
let killed = false;
process.once('exit', killChrome);
if (temporaryUserDataDir) if (temporaryUserDataDir)
chromeProcess.once('close', () => removeSync(temporaryUserDataDir)); chromeProcess.once('close', () => removeSync(temporaryUserDataDir));
const listeners = [ helper.addEventListener(process, 'exit', killChrome) ];
if (options.handleSIGINT !== false) if (options.handleSIGINT !== false)
process.once('SIGINT', killChrome); listeners.push(helper.addEventListener(process, 'SIGINT', killChrome));
try { try {
const connectionDelay = options.slowMo || 0; const connectionDelay = options.slowMo || 0;
@ -104,9 +103,7 @@ class Launcher {
} }
function killChrome() { function killChrome() {
if (killed) helper.removeEventListeners(listeners);
return;
killed = true;
if (process.platform === 'win32') if (process.platform === 'win32')
childProcess.execSync(`taskkill /pid ${chromeProcess.pid} /T /F`); childProcess.execSync(`taskkill /pid ${chromeProcess.pid} /T /F`);
else else