From cd54ce388eec426034ae7b7ee5058e54b5ac5da8 Mon Sep 17 00:00:00 2001 From: Joel Einbinder Date: Wed, 3 Oct 2018 16:59:49 -0700 Subject: [PATCH] fix(types): upgrade node types to 8.10.34 (#3341) --- lib/Launcher.js | 1 - lib/NetworkManager.js | 4 +--- package.json | 2 +- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/Launcher.js b/lib/Launcher.js index 4c4ced7a..63b825ad 100644 --- a/lib/Launcher.js +++ b/lib/Launcher.js @@ -164,7 +164,6 @@ class Launcher { const transport = await WebSocketTransport.create(browserWSEndpoint); connection = new Connection(browserWSEndpoint, transport, slowMo); } else { - // @ts-ignore - TypeScript incorrectly thinks stdio can't go above 2 const transport = new PipeTransport(/** @type {!NodeJS.WritableStream} */(chromeProcess.stdio[3]), /** @type {!NodeJS.ReadableStream} */ (chromeProcess.stdio[4])); connection = new Connection('', transport, slowMo); } diff --git a/lib/NetworkManager.js b/lib/NetworkManager.js index 9a2e82b4..38b0926e 100644 --- a/lib/NetworkManager.js +++ b/lib/NetworkManager.js @@ -430,10 +430,8 @@ class Request { } if (response.contentType) responseHeaders['content-type'] = response.contentType; - if (responseBody && !('content-length' in responseHeaders)) { - // @ts-ignore + if (responseBody && !('content-length' in responseHeaders)) responseHeaders['content-length'] = Buffer.byteLength(responseBody); - } const statusCode = response.status || 200; const statusText = statusTexts[statusCode] || ''; diff --git a/package.json b/package.json index e678f5a6..ef323ddc 100644 --- a/package.json +++ b/package.json @@ -44,7 +44,7 @@ "@types/debug": "0.0.30", "@types/extract-zip": "^1.6.2", "@types/mime": "^2.0.0", - "@types/node": "^8.10.32", + "@types/node": "^8.10.34", "@types/rimraf": "^2.0.2", "@types/ws": "^3.0.2", "commonmark": "^0.27.0",