From ce08fc77b10d975609f54ce5454e4e4ac745d159 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Tue, 22 Aug 2017 14:15:02 -0700 Subject: [PATCH] Roll chromium to r496140 (#465) This patch rolls chromium to r496140. This includes the r496130 that introduces multiple sessions for single target. With this patch, it is possible to run puppeteer in headful mode and open devtools over the automated pages without puppeteer losing connection to the page. --- lib/Launcher.js | 1 + package.json | 2 +- test/test.js | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/Launcher.js b/lib/Launcher.js index d76a5baf..48b4fc6d 100644 --- a/lib/Launcher.js +++ b/lib/Launcher.js @@ -37,6 +37,7 @@ const DEFAULT_ARGS = [ '--disable-prompt-on-repost', '--disable-sync', '--enable-automation', + '--enable-devtools-experiments', '--metrics-recording-only', '--no-first-run', '--password-store=basic', diff --git a/package.json b/package.json index 59a754b6..fa130906 100644 --- a/package.json +++ b/package.json @@ -29,7 +29,7 @@ "ws": "^3.0.0" }, "puppeteer": { - "chromium_revision": "494755" + "chromium_revision": "496140" }, "devDependencies": { "commonmark": "^0.27.0", diff --git a/test/test.js b/test/test.js index acf55d69..24f42ba6 100644 --- a/test/test.js +++ b/test/test.js @@ -562,7 +562,7 @@ describe('Page', function() { it('should fail when main resources failed to load', SX(async function() { let error = null; try { - await page.goto('chrome-devtools://non-existing.html'); + await page.goto('http://localhost:44123/non-existing-url'); } catch (e) { error = e; }