diff --git a/package.json b/package.json index 8a927d8a..585fdf51 100644 --- a/package.json +++ b/package.json @@ -29,7 +29,7 @@ "ws": "^3.0.0" }, "puppeteer": { - "chromium_revision": "490379" + "chromium_revision": "491334" }, "devDependencies": { "commonmark": "^0.27.0", diff --git a/test/test.js b/test/test.js index 47508b2d..3c65db12 100644 --- a/test/test.js +++ b/test/test.js @@ -755,14 +755,14 @@ describe('Page', function() { }); describe('Page.Events.Dialog', function() { - it('should fire', function(done) { + it('should fire', SX(async function() { page.on('dialog', dialog => { expect(dialog.type).toBe('alert'); expect(dialog.message()).toBe('yo'); - done(); + dialog.accept(); }); - page.evaluate(() => alert('yo')); - }); + await page.evaluate(() => alert('yo')); + })); // TODO Enable this when crbug.com/718235 is fixed. (headless ? xit : it)('should allow accepting prompts', SX(async function(done) { page.on('dialog', dialog => { diff --git a/third_party/phantomjs/test/module/webpage/on-confirm.js b/third_party/phantomjs/test/module/webpage/on-confirm.js index 2f0f2ac8..f4f6e31c 100644 --- a/third_party/phantomjs/test/module/webpage/on-confirm.js +++ b/third_party/phantomjs/test/module/webpage/on-confirm.js @@ -30,7 +30,4 @@ test(function () { page.onConfirm = undefined; assert_equals(page.onConfirm, undefined); -}, "page.onConfirm", { - /* @see crbug.com/718235 */ - expected_fail: true -}); +}, "page.onConfirm");