From e7b0e0f4489ed43c94c217548a1b30b9b852a467 Mon Sep 17 00:00:00 2001 From: Joel Einbinder Date: Fri, 13 Jul 2018 11:07:24 -0700 Subject: [PATCH] feat(chromium): roll Chromium to r574897 (#2887) This roll includes: - https://crrev.com/574785 - DevTools: allow tracing over the remote debugging pipe. This fixes tracing over the remote debugging pipe. --- lib/Pipe.js | 8 ++++---- package.json | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/Pipe.js b/lib/Pipe.js index c08dea11..2bf35be4 100644 --- a/lib/Pipe.js +++ b/lib/Pipe.js @@ -35,14 +35,14 @@ class Pipe extends EventEmitter { */ send(message) { this._pipeWrite.write(message); - this._pipeWrite.write('\n'); + this._pipeWrite.write('\0'); } /** * @param {!Buffer} buffer */ _dispatch(buffer) { - let end = buffer.indexOf('\n'); + let end = buffer.indexOf('\0'); if (end === -1) { this._pendingMessage += buffer.toString(); return; @@ -51,11 +51,11 @@ class Pipe extends EventEmitter { this.emit('message', message); let start = end + 1; - end = buffer.indexOf('\n', start); + end = buffer.indexOf('\0', start); while (end !== -1) { this.emit('message', buffer.toString(undefined, start, end)); start = end + 1; - end = buffer.indexOf('\n', start); + end = buffer.indexOf('\0', start); } this._pendingMessage = buffer.toString(undefined, start); } diff --git a/package.json b/package.json index c77379a5..d2b1f981 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,7 @@ "node": ">=6.4.0" }, "puppeteer": { - "chromium_revision": "571375" + "chromium_revision": "574897" }, "scripts": { "unit": "node test/test.js",