thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

docs: move ProductLauncher to abstract class (#11324)

Browse Source
This commit is contained in:
Nikolay Vitkov 2023-11-08 19:36:56 +01:00 committed by GitHub
parent 1927fb561e
commit f7cf05ce4a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/api/puppeteer.productlauncher.defaultargs.md
View File

@ -8,7 +8,7 @@ sidebar_label: ProductLauncher.defaultArgs
```typescript
class ProductLauncher {
defaultArgs(object: BrowserLaunchArgumentOptions): string[];
abstract defaultArgs(object: BrowserLaunchArgumentOptions): string[];
}
```

2
docs/api/puppeteer.productlauncher.executablepath.md
View File

@ -8,7 +8,7 @@ sidebar_label: ProductLauncher.executablePath
```typescript
class ProductLauncher {
executablePath(channel?: ChromeReleaseChannel): string;
abstract executablePath(channel?: ChromeReleaseChannel): string;
}
```

2
docs/api/puppeteer.productlauncher.md
View File

@ -9,7 +9,7 @@ Describes a launcher - a class that is able to create and launch a browser insta
#### Signature:
```typescript
export declare class ProductLauncher
export declare abstract class ProductLauncher
```
## Remarks

22
packages/puppeteer-core/src/node/ProductLauncher.ts
View File

@ -58,7 +58,7 @@ export interface ResolvedLaunchArgs {
*
* @public
*/
export class ProductLauncher {
export abstract class ProductLauncher {
#product: Product;
/**
@ -201,15 +201,9 @@ export class ProductLauncher {
return browser;
}
executablePath(channel?: ChromeReleaseChannel): string;
executablePath(): string {
throw new Error('Not implemented');
}
abstract executablePath(channel?: ChromeReleaseChannel): string;
defaultArgs(object: BrowserLaunchArgumentOptions): string[];
defaultArgs(): string[] {
throw new Error('Not implemented');
}
abstract defaultArgs(object: BrowserLaunchArgumentOptions): string[];
/**
* Set only for Firefox, after the launcher resolves the `latest` revision to
@ -223,23 +217,17 @@ export class ProductLauncher {
/**
* @internal
*/
protected async computeLaunchArguments(
protected abstract computeLaunchArguments(
options: PuppeteerNodeLaunchOptions
): Promise<ResolvedLaunchArgs>;
protected async computeLaunchArguments(): Promise<ResolvedLaunchArgs> {
throw new Error('Not implemented');
}
/**
* @internal
*/
protected async cleanUserDataDir(
protected abstract cleanUserDataDir(
path: string,
opts: {isTemp: boolean}
): Promise<void>;
protected async cleanUserDataDir(): Promise<void> {
throw new Error('Not implemented');
}
/**
* @internal