thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: enable anchor navigation tests for Firefox (#8394)

Browse Source
This commit is contained in:
Julian Descottes 2022-05-25 08:46:17 +02:00 committed by GitHub
parent 3dae2b4549
commit f866274360
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
test/frame.spec.ts
View File

@ -134,19 +134,16 @@ describe('Frame specs', function () {
expect(detachedFrames[0].isDetached()).toBe(true);
}
);
itFailsFirefox(
'should send "framenavigated" when navigating on anchor URLs',
async () => {
const { page, server } = getTestState();
it('should send "framenavigated" when navigating on anchor URLs', async () => {
const { page, server } = getTestState();
await page.goto(server.EMPTY_PAGE);
await Promise.all([
page.goto(server.EMPTY_PAGE + '#foo'),
utils.waitEvent(page, 'framenavigated'),
]);
expect(page.url()).toBe(server.EMPTY_PAGE + '#foo');
}
);
await page.goto(server.EMPTY_PAGE);
await Promise.all([
page.goto(server.EMPTY_PAGE + '#foo'),
utils.waitEvent(page, 'framenavigated'),
]);
expect(page.url()).toBe(server.EMPTY_PAGE + '#foo');
});
it('should persist mainFrame on cross-process navigation', async () => {
const { page, server } = getTestState();
@ -164,7 +161,7 @@ describe('Frame specs', function () {
await page.goto(server.EMPTY_PAGE);
expect(hasEvents).toBe(false);
});
itFailsFirefox('should detach child frames on navigation', async () => {
it('should detach child frames on navigation', async () => {
const { page, server } = getTestState();
let attachedFrames = [];
@ -186,7 +183,7 @@ describe('Frame specs', function () {
expect(detachedFrames.length).toBe(4);
expect(navigatedFrames.length).toBe(1);
});
itFailsFirefox('should support framesets', async () => {
it('should support framesets', async () => {
const { page, server } = getTestState();
let attachedFrames = [];

6
test/navigation.spec.ts
View File

@ -35,7 +35,7 @@ describe('navigation', function () {
await page.goto(server.EMPTY_PAGE);
expect(page.url()).toBe(server.EMPTY_PAGE);
});
itFailsFirefox('should work with anchor navigation', async () => {
it('should work with anchor navigation', async () => {
const { page, server } = getTestState();
await page.goto(server.EMPTY_PAGE);
@ -488,7 +488,7 @@ describe('navigation', function () {
});
describe('Page.waitForNavigation', function () {
itFailsFirefox('should work', async () => {
it('should work', async () => {
const { page, server } = getTestState();
await page.goto(server.EMPTY_PAGE);
@ -526,7 +526,7 @@ describe('navigation', function () {
await bothFiredPromise;
await navigationPromise;
});
itFailsFirefox('should work with clicking on anchor links', async () => {
it('should work with clicking on anchor links', async () => {
const { page, server } = getTestState();
await page.goto(server.EMPTY_PAGE);