thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: try to remove the temporary user data directory after the process has been killed (#7761)

Browse Source
This commit is contained in:
Henrik Skupin 2021-11-15 12:52:09 +01:00 committed by GitHub
parent 7c0a7b92cf
commit fc94a28778
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/node/BrowserRunner.ts
View File

@ -180,13 +180,6 @@ export class BrowserRunner {
} }
kill(): void { kill(): void {
// Attempt to remove temporary profile directory to avoid littering.
try {
if (this._isTempUserDataDir) {
removeFolder.sync(this._userDataDir);
}
} catch (error) {}
// If the process failed to launch (for example if the browser executable path // If the process failed to launch (for example if the browser executable path
// is invalid), then the process does not get a pid assigned. A call to // is invalid), then the process does not get a pid assigned. A call to
// `proc.kill` would error, as the `pid` to-be-killed can not be found. // `proc.kill` would error, as the `pid` to-be-killed can not be found.
@ -199,6 +192,14 @@ export class BrowserRunner {
); );
} }
} }
// Attempt to remove temporary profile directory to avoid littering.
try {
if (this._isTempUserDataDir) {
removeFolder.sync(this._userDataDir);
}
} catch (error) {}
// Cleanup this listener last, as that makes sure the full callback runs. If we // Cleanup this listener last, as that makes sure the full callback runs. If we
// perform this earlier, then the previous function calls would not happen. // perform this earlier, then the previous function calls would not happen.
helper.removeEventListeners(this._listeners); helper.removeEventListeners(this._listeners);