Commit Graph

3114 Commits

Author SHA1 Message Date
Alex Rudenko
eda182741b
docs: add bug triage guidelines (#9305)
Co-authored-by: Mathias Bynens <mathias@qiwi.be>
2022-11-23 11:51:25 +01:00
Joe Gomain Hoyes
bef1061c06
feat(puppeteer-core): Infer element type from complex selector (#9253)
**What kind of change does this PR introduce?**

Better type inference.

**Did you add tests for your changes?**

~Not yet.~ Yes.

**If relevant, did you update the documentation?**

Not yet.

**Summary**

<!-- Explain the **motivation** for making this change. What existing
problem does the pull request solve? -->
<!-- Try to link to an open issue for more information. -->
Currently methods that return an element handle, i.e. `.$`,
`.waitForSelector` attempt to infer the node element type from the
selector string. However, this only works when the selector is an exact
match of the element tag, i.e. a selector `"a"` would be inferred as
`HTMLAnchorElement` . And not when the selector is complex, i.e.
selectors `"a#some-id"`, `div > a`, `a:nth-child(2)` would all fallback
on `Element`.

This is due to simply looking up the the selector in
`HTMLElementTagNameMap` and `SVGElementTagNameMap` without any attempt
to parse the selector string.

This PR is an attempt to do so.

**Does this PR introduce a breaking change?**

<!-- If this PR introduces a breaking change, please describe the impact
and a migration path for existing applications. -->
This could break existing incorrect assertions using the `as` keyword.

**Other information**

~This PR introduces a dependency on the `type-fest` package.~

This PR is far from complete (no tests, no docs). Put out early for
feedback and discussion.

Co-authored-by: Alex Rudenko <OrKoN@users.noreply.github.com>
2022-11-23 10:59:23 +01:00
Nikolay Vitkov
16784fc8cb chore(ng-schematics): Update ng e2e to custom builder (#9300)
**What kind of change does this PR introduce?**

This replaces the default `ng e2e` with our custom builder. In the
feature it seem possible to remove the necessity of the user running the
server separately and run it from the builder - that will improve the
easy of use and CI of this schematic.

**Did you add tests for your changes?**

**If relevant, did you update the documentation?**

Yes - Updated `@puppeteer/ng-schematics` README.md

**Summary**

We want to not see the default `ng e2e` and we want to make it easier
for the user to run commands.
Angular Developer are likely to also use its' CLI.

**Does this PR introduce a breaking change?**

Yes. Users need to delete the default and initialize the schematics
again.

**Other information**
2022-11-22 19:52:29 +01:00
Alex Rudenko
0107ad8f08
chore: use groupName in release-please manifest (#9292)
release-please does not handle `group-name` currently but very likely it
will in the future.
2022-11-17 18:06:00 +01:00
Guillaume Gomez
0a2d310e4e
docs: fix typo in Viewport fields (#9293)
The `deviceScalarFactor` field of `Viewport` is actually named
`deviceScaleFactor`.
2022-11-17 17:27:07 +01:00
Thiago Perrotta
b6ffa732ac
docs: fix cross-browser.js example (#9291)
The previous selector is broken as of ~2 months ago, c.f.
https://news.ycombinator.com/item?id=33027700

Changed from:

    <a class="titlelink"></a>

To:

    <span class="titleline">
    <a></a>
    </span>
2022-11-17 13:26:08 +01:00
Alex Rudenko
078d385671
chore(ng-schematics): publish v0.0.1 (#9290) 2022-11-17 10:22:53 +01:00
jrandolf
65007a29b5
chore: deprecate old versions (#9277) 2022-11-15 12:54:25 +01:00
Nikolay Vitkov
be33929770
feat(ng-schematics): Release @puppeteer/ng-schematics (#9244)
**What kind of change does this PR introduce?**

Adds `@puppeteer/ng-schematics` to the list of packages to be published
to `npm`

**Did you add tests for your changes?**

Not relevant.

**If relevant, did you update the documentation?**

Not for in this PR.

**Summary**

We want to publish to `npm` so people can do `ng add
@puppeteer/ng-schematics` and use it with Angular CLI.

**Does this PR introduce a breaking change?**

No

**Other information**
2022-11-14 18:24:17 +01:00
Nikolay Vitkov
1b3dfeca98
chore: Update ng-schemactics README (#9269)
**What kind of change does this PR introduce?**

Updates the README for `@puppeteer/ng-schematics` with better
information. Fixes broken command
2022-11-14 15:18:03 +01:00
Nikolay Vitkov
57f7366eb8
chore: Add Node testing option in ng-schematics (#9266)
**What kind of change does this PR introduce?**

It lets Users create an schematic for Puppeteer in Angular project using
Node's new test runner.

**Did you add tests for your changes?**

Yes. Unit test for module.

**If relevant, did you update the documentation?**

No

**Summary**

**Does this PR introduce a breaking change?**

No

**Other information**
2022-11-14 12:57:42 +01:00
jrandolf
e003513c0c
fix: remove boundary conditions for visibility (#9249)
Fixed: https://github.com/puppeteer/puppeteer/issues/9232
2022-11-14 09:34:07 +01:00
Nikolay Vitkov
86abe68849
chore: Add Mocha option to ng-schematic (#9259)
**What kind of change does this PR introduce?**

Adds Mocha as option for `ng-schematics`

**Did you add tests for your changes?**

Yes

**If relevant, did you update the documentation?**

No

**Summary**

User want a simple solution for the Testing library of their choose 

**Does this PR introduce a breaking change?**

No

**Other information**
There are some improvements around the Babel that we can make so we
don't have duplicate code and files (In a Feature PR)
2022-11-14 09:30:49 +01:00
Nikolay Vitkov
1bbecb3bae
chore: Add Jest as a ng-schematics option (#9257)
**What kind of change does this PR introduce?**

Adds Jest in `ng-schematics`. So you can scaffold test with Jest instead
of Jasmine

**Did you add tests for your changes?**

Yes

**If relevant, did you update the documentation?**

No

**Summary**

Users can more easily integrate test with Puppeteer and their library of
choose.

**Does this PR introduce a breaking change?**

No

**Other information**
2022-11-11 14:38:52 +01:00
Alex Rudenko
9545691b1e
chore: define release-please component (#9252) 2022-11-11 11:43:11 +01:00
Alex Rudenko
b57b5b35a9
chore: try linked versions for release (#9245)
Let's give this plugin a try? with dependency pinning it seems useful to
make sure these packages get released together.
2022-11-11 11:01:43 +01:00
Alex Rudenko
e55fed9d49
chore: use npm 8.3 on windows with node 14 (#9246)
Workaround for https://github.com/npm/cli/issues/4341#issue-1117047096
2022-11-11 09:34:13 +01:00
Alex Rudenko
30c6b13eec
chore: re-export all exports (#9241)
Adds index files to subfolders and removes generation of types.ts in
puppeteer-core.
2022-11-10 17:11:18 +01:00
Nikolay Vitkov
15604f474a
chore: Add schematics tests to CI (#9235)
**What kind of change does this PR introduce?**

Add CI for testing Schematics.

**Did you add tests for your changes?**

Not relevant.

**If relevant, did you update the documentation?**

Not relevant.

**Summary**

We want to check if tests for `@puppeteer/ng-schematics` are passing
after

**Does this PR introduce a breaking change?**

No

**Other information**
2022-11-10 15:26:46 +01:00
Alex Rudenko
ae87bfc2b4
feat(puppeteer-core): update Chrome launcher flags (#9239)
This PR adds:
- `--disable-component-update`
- `--disable-features=MediaRouter`
- `--disable-features=OptimizationHints`

and removes `--disable-features=AvoidUnnecessaryBeforeUnloadCheckSync`.

See
https://github.com/GoogleChrome/chrome-launcher/blob/main/docs/chrome-flags-for-tools.md
2022-11-10 11:43:37 +01:00
Nikolay Vitkov
3f2c0590f1
chore(ng-schematics): Add Angular Schematics (#9222)
**What kind of change does this PR introduce?**

It introduces schematic for Angular that integrate with its CLI.
First revision support Jasmine.

**Did you add tests for your changes?**

Added Unit tests for each scenario. 

**Summary**

The idea is to provide a an example for setting up Puppeteer and Angular
for testing user flows.

**Does this PR introduce a breaking change?**

No

**Other information**

For Feature PRs:

- Introduce CL for tests
- Hook up NPM package publishing
- Update README.md
2022-11-09 14:52:10 +01:00
jrandolf
8c211d6ae4
chore: update bug template (#9225) 2022-11-08 10:28:35 +01:00
dependabot[bot]
3e8363eb80
chore(deps): bump ossf/scorecard-action from 2.0.3 to 2.0.6 (#9170)
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action)
from 2.0.3 to 2.0.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/ossf/scorecard-action/releases">ossf/scorecard-action's
releases</a>.</em></p>
<blockquote>
<h2>v2.0.6</h2>
<h2>What's Changed</h2>
<ul>
<li>Fix - Broken dockerfile by <a
href="https://github.com/naveensrinivasan"><code>@​naveensrinivasan</code></a>
in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/979">ossf/scorecard-action#979</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/ossf/scorecard-action/compare/v2.0.5...v2.0.6">https://github.com/ossf/scorecard-action/compare/v2.0.5...v2.0.6</a></p>
<h2>v2.0.5</h2>
<h2>What's Changed</h2>
<ul>
<li>Remove trailing space from example by <a
href="https://github.com/jamacku"><code>@​jamacku</code></a> in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/955">ossf/scorecard-action#955</a></li>
<li>🌱 Bump actions/cache from 3.0.8 to 3.0.10 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/956">ossf/scorecard-action#956</a></li>
<li>🌱 Bump github/codeql-action from 2.1.25 to 2.1.26 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/957">ossf/scorecard-action#957</a></li>
<li>🌱 Bump step-security/harden-runner from 1.4.5 to 1.5.0 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/958">ossf/scorecard-action#958</a></li>
<li>🌱 Bump debian from <code>5cf1d98</code> to
<code>b46fc4e</code> by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/959">ossf/scorecard-action#959</a></li>
<li>🌱 Bump github.com/sigstore/cosign from 1.12.1 to 1.13.0 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/962">ossf/scorecard-action#962</a></li>
<li>🌱 Upgrade to go 1.19 by <a
href="https://github.com/naveensrinivasan"><code>@​naveensrinivasan</code></a>
in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/961">ossf/scorecard-action#961</a></li>
<li>🌱 Bump github.com/spf13/cobra from 1.5.0 to 1.6.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/967">ossf/scorecard-action#967</a></li>
<li>🌱 Bump golang from <code>c2a98a5</code> to
<code>b850621</code> by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/966">ossf/scorecard-action#966</a></li>
<li>🌱 Bump golang from <code>b850621</code> to
<code>25de7b6</code> by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/968">ossf/scorecard-action#968</a></li>
<li>New release for Scorecard v4.8.0 by <a
href="https://github.com/naveensrinivasan"><code>@​naveensrinivasan</code></a>
in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/969">ossf/scorecard-action#969</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/jamacku"><code>@​jamacku</code></a> made
their first contribution in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/955">ossf/scorecard-action#955</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/ossf/scorecard-action/compare/v2.0.4...v2.0.5">https://github.com/ossf/scorecard-action/compare/v2.0.4...v2.0.5</a></p>
<h2>v2.0.4</h2>
<p>Fixes <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/issues/856">#856</a></p>
<h2>What's Changed</h2>
<ul>
<li>🌱 Bump github.com/caarlos0/env/v6 from 6.10.0 to 6.10.1 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/934">ossf/scorecard-action#934</a></li>
<li>feat: do not run signing on pull requests by <a
href="https://github.com/laurentsimon"><code>@​laurentsimon</code></a>
in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/935">ossf/scorecard-action#935</a></li>
<li>🌱 Bump debian from 11.4-slim to 11.5-slim by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/936">ossf/scorecard-action#936</a></li>
<li>🌱 Bump github.com/sigstore/cosign from 1.11.1 to 1.12.0 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/938">ossf/scorecard-action#938</a></li>
<li>🌱 Bump github/codeql-action from 2.1.22 to 2.1.24 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/941">ossf/scorecard-action#941</a></li>
<li>🐛 Restore behavior of ignoring scorecard runtime errors by <a
href="https://github.com/spencerschrock"><code>@​spencerschrock</code></a>
in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/948">ossf/scorecard-action#948</a></li>
<li>🌱 Bump actions/dependency-review-action from 2.1.0 to 2.4.0
by <a href="https://github.com/dependabot"><code>@​dependabot</code></a>
in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/950">ossf/scorecard-action#950</a></li>
<li>🌱 Bump github.com/sigstore/cosign from 1.12.0 to 1.12.1 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/947">ossf/scorecard-action#947</a></li>
<li>🌱 Bump github/codeql-action from 2.1.24 to 2.1.25 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/949">ossf/scorecard-action#949</a></li>
<li>🌱 Bump codecov/codecov-action from 3.1.0 to 3.1.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/942">ossf/scorecard-action#942</a></li>
<li>Create v2.0.4 patch by <a
href="https://github.com/spencerschrock"><code>@​spencerschrock</code></a>
in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/952">ossf/scorecard-action#952</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/spencerschrock"><code>@​spencerschrock</code></a>
made their first contribution in <a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/pull/948">ossf/scorecard-action#948</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/ossf/scorecard-action/compare/v2.0.3...v2.0.4">https://github.com/ossf/scorecard-action/compare/v2.0.3...v2.0.4</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="99c53751e0"><code>99c5375</code></a>
Fix - Broken dockerfile (<a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/issues/979">#979</a>)</li>
<li><a
href="ff6221f234"><code>ff6221f</code></a>
New release for Scorecard v4.8.0 (<a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/issues/969">#969</a>)</li>
<li><a
href="608d088417"><code>608d088</code></a>
🌱 Bump golang from <code>b850621</code> to <code>25de7b6</code>
(<a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/issues/968">#968</a>)</li>
<li><a
href="5e97403151"><code>5e97403</code></a>
🌱 Bump golang from <code>c2a98a5</code> to <code>b850621</code>
(<a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/issues/966">#966</a>)</li>
<li><a
href="851b893ef5"><code>851b893</code></a>
🌱 Bump github.com/spf13/cobra from 1.5.0 to 1.6.0 (<a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/issues/967">#967</a>)</li>
<li><a
href="c9866174c7"><code>c986617</code></a>
🌱 Upgrade to go 1.19 (<a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/issues/961">#961</a>)</li>
<li><a
href="c3d8fd9ebe"><code>c3d8fd9</code></a>
🌱 Bump github.com/sigstore/cosign from 1.12.1 to 1.13.0 (<a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/issues/962">#962</a>)</li>
<li><a
href="6075f427dd"><code>6075f42</code></a>
🌱 Bump debian from <code>5cf1d98</code> to <code>b46fc4e</code>
(<a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/issues/959">#959</a>)</li>
<li><a
href="f3005530a0"><code>f300553</code></a>
🌱 Bump step-security/harden-runner from 1.4.5 to 1.5.0 (<a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/issues/958">#958</a>)</li>
<li><a
href="de0b2c5459"><code>de0b2c5</code></a>
🌱 Bump github/codeql-action from 2.1.25 to 2.1.26 (<a
href="https://github-redirect.dependabot.com/ossf/scorecard-action/issues/957">#957</a>)</li>
<li>Additional commits viewable in <a
href="865b409285...99c53751e0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ossf/scorecard-action&package-manager=github_actions&previous-version=2.0.3&new-version=2.0.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-03 16:18:02 +00:00
jrandolf
be5d9dbaa9
docs: fix search bar (#9214) 2022-11-03 13:02:25 +01:00
jrandolf
641a326541
chore: update contributing (#9202) 2022-11-03 11:08:36 +01:00
release-please[bot]
30e5b1a58e
chore: release main (#9210) 2022-11-03 11:02:28 +01:00
jrandolf
65386b3d0c
chore: revert "chore: fix pre-release" (#9211)
Reverts puppeteer/puppeteer#9199
2022-11-03 10:09:15 +01:00
jrandolf
d011ca8616
docs: use algolia (#9208)
This PR adds algolia search to the documentation.
2022-11-03 09:40:12 +01:00
jrandolf
29f47e2e15
fix: update missing product message (#9207)
This PR updates the error message printed when a browser cannot be
found.

Related: https://github.com/puppeteer/puppeteer/issues/9192,
https://github.com/puppeteer/puppeteer/issues/9162
2022-11-03 09:32:17 +01:00
Renaud Lataguerra
09253ba54d
docs: update examples' README (#9187)
This PR update the examples` `README` file to add Doppio.sh in the services list.
2022-11-02 11:48:27 +01:00
jrandolf
e2aaa553fe
chore: fix pre-release (#9199)
This PR enables `pre-release` only for the release PRs.
2022-11-02 11:44:26 +01:00
jrandolf
a9bde8e726
chore: update puppeteer changelog (#9200) 2022-11-02 11:42:37 +01:00
release-please[bot]
990635abc9
chore: release main (#9184)
🤖 I have created a release *beep* *boop*
---


<details><summary>puppeteer: 19.2.1</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * puppeteer-core bumped from 19.2.0 to ^19.2.1
</details>

<details><summary>puppeteer-core: 19.2.1</summary>

##
[19.2.1](https://github.com/puppeteer/puppeteer/compare/puppeteer-core-v19.2.0...puppeteer-core-v19.2.1)
(2022-10-28)


### Bug Fixes

* resolve navigation requests when request fails
([#9178](https://github.com/puppeteer/puppeteer/issues/9178))
([c11297b](c11297baa5)),
closes [#9175](https://github.com/puppeteer/puppeteer/issues/9175)
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
2022-11-02 10:54:37 +01:00
jrandolf
6bf5f435b8
chore: disable install checks on release PRs (#9183) 2022-10-28 12:46:45 +02:00
Nikolay Vitkov
adbc2cf261
docs: Fix broken link in issues (#9181) 2022-10-28 12:07:05 +02:00
jrandolf
8c9308d3dc
docs: remove unsupported debugging method (#9182)
`ndb` is no longer maintained.
2022-10-28 11:04:05 +02:00
Alex Rudenko
c11297baa5
fix: resolve navigation requests when request fails (#9178)
#8768 fixes flakiness in handling navigations but it didn't account for
the fact that subsequent navigation requests could be aborted via the
request interception. In that case, the navigationResponseReceived
promise would never be resolved. This PR adds a listener for the failed
network requests and resolves the promise if the network request has
failed. Adding test coverage for this seems tricky, as the reproduction
depends on timing of the second navigation request.

Closes #9175
2022-10-28 09:56:06 +02:00
jrandolf
2d2120cea1
docs: improve docs (#9179)
This PR drastically improves the documentation by improving the sidebars
and adding a GitHub icon.

Fixed: https://github.com/puppeteer/puppeteer/pull/9176
Fixed: https://github.com/puppeteer/puppeteer/issues/9173


![image](https://user-images.githubusercontent.com/101637635/198374826-399219f6-e04f-4613-9613-f7e3281d332f.png)
2022-10-28 08:49:28 +02:00
Nikolay Vitkov
f3ff18e468
chore: Added Configuration to Bug Template (#9172) 2022-10-27 20:35:21 +02:00
Alexandra Borovova
9e95774596
chore: add missing golden asset for firefox (#9171)
<!-- Thanks for submitting a pull request! Please provide enough
information so that others can review your pull request. -->

**What kind of change does this PR introduce?**

- adds missing golden asset for firefox

**Summary**

- This change will let us see in mozilla ci, where we don't skip this
test, a better error message. Right now it fails with missing asset
error.

**Does this PR introduce a breaking change?**
no
2022-10-27 09:33:38 +00:00
release-please[bot]
4ef83e0ee6
chore: release main (#9168) 2022-10-26 09:51:16 +02:00
dependabot[bot]
0d4607905d
chore(deps): bump docker/login-action from 2.0.0 to 2.1.0 (#9113) 2022-10-25 15:33:28 +02:00
dependabot[bot]
bb17b011a4
chore(deps): bump docker/metadata-action from 4.0.1 to 4.1.1 (#9127) 2022-10-25 15:32:22 +02:00
dependabot[bot]
e19dd6c92c
chore(deps): bump ws from 8.9.0 to 8.10.0 (#9159) 2022-10-25 15:31:48 +02:00
Alex Rudenko
e78a4e89c2
feat(chromium): roll to Chromium 108.0.5351.0 (r1056772) (#9153) 2022-10-25 12:55:19 +02:00
release-please[bot]
fe4fcf6019
chore: release main (#9161) 2022-10-25 11:12:17 +02:00
jrandolf
2245d7d6ed
fix: skip browser download (#9160)
Fixed: https://github.com/puppeteer/puppeteer/issues/9158
2022-10-25 11:02:40 +02:00
Randolf
088c18c842 chore: update changelog 2022-10-25 10:26:33 +02:00
release-please[bot]
b020c5746d
chore: release main (#9156) 2022-10-24 16:31:12 +02:00
jrandolf
95d77c679c
chore: revert "chore: release main" (#9155)
Reverts puppeteer/puppeteer#9152
2022-10-24 16:23:24 +02:00