JoelEinbinder
e6d8fca7cd
Lint examples, again #178 ( #190 )
2017-08-02 15:03:26 -07:00
JoelEinbinder
0218960713
Revert "lint examples #178 ( #182 )" ( #183 )
...
This reverts commit 8c220654e8
.
2017-08-02 01:26:02 -07:00
JoelEinbinder
8c220654e8
lint examples #178 ( #182 )
...
This patch enables lint in `examples/` folder.
2017-08-02 01:13:44 -07:00
Andrey Lushnikov
2ca08b032b
Rename Page's 'consolemessage' event into 'console'
...
This patch:
- renames 'consolemessage' event into 'console'
- improves on 'console' event documentation
References #39 .
2017-07-17 20:38:11 -07:00
Paul Irish
6c7ae41ae6
fix page.injectFile and add test. ( #52 )
...
This line within `injectFile` wasn't doing much of anything:
```js
let expression = fs.readFile(filePath, 'utf8', (err, data) => callback({err, data}));
```
* That's fixed.
* A path error in examples/features.js is fixed.
* Test added for injectFile.
2017-07-07 02:09:23 +03:00
Andrey Lushnikov
939038bb08
Convert event names to small caps
...
This patch takes inspiration from DOM events and makes all the
events small-caps.
2017-05-13 12:04:30 -07:00
Andrey Lushnikov
15b36b1cf0
Drop unneeded Page Event's prefixes.
...
This patch drops 'Page.Event.' prefix in every puppeteer's page
event. This makes it convenient to subscribe to events by their
string value.
2017-05-13 11:12:06 -07:00
Andrey Lushnikov
8a8076c15b
Rename Page.Events.ConsoleMessageAdded -> Page.Events.ConsoleMessage
...
This patch:
- renames ConsoleMessageAdded into ConsoleMessage for the sake of
clarity
- adds a test to cover basic functionality
2017-05-13 11:05:54 -07:00
Andrey Lushnikov
ab6a96a991
Fix License header of certain examples
...
Certain examples rely extensively on the originating PhantomJS
examples.
This patch fixes license headers of these examples to mention
PhantomJS authors.
2017-05-12 16:48:02 -07:00
Andrey Lushnikov
62e68159f4
Re-implement phantom's examples/features.js in puppeteer api.
2017-05-12 14:57:55 -07:00