Commit Graph

4 Commits

Author SHA1 Message Date
Pavel Feldman
73fd7ff822 feat(api): add element.select and element.evaluate for consistency () 2019-09-04 15:19:34 -07:00
Andrey Lushnikov
5ee21d97e7
fix(page): intersect content quads with viewport ()
In certain cases inline element children might be positioned
outside of viewport.

In this case, we should intersect all content quads with viewport
before we pick one to click into.

Fixes .
2019-04-11 21:11:20 -04:00
Andrey Lushnikov
62da2366c6
chore: introduce //lib/api.js ()
Introduce `//lib/api.js` that declares a list of publicly exposed
classes.

The `//lib/api.js` list superceedes dynamic `helper.tracePublicAPI()` calls
and is used in the following places:
- [ASYNC STACKS]: generate "async stacks" for publicy exposed API in `//index.js`
- [COVERAGE]: move coverage support from `//lib/helper` to `//test/utils`
- [DOCLINT]: get rid of 'exluded classes' hardcoded list

This will help us to re-use our coverage and doclint infrastructure
for Puppeteer-Firefox.

Drive-By: it turns out we didn't run coverage for `SecurityDetails`
class, so we lack coverage for a few methods there. These are excluded
for now, sanity tests will be added in a follow-up.
2019-01-25 23:21:14 -05:00
Andrey Lushnikov
e8bb26eb95
refactor: split out classes into files ()
New files:
- LifecycleWatcher
- JSHandle
2019-01-14 20:34:50 -08:00