This PR fixes the following edge case:
- `const oldPromise = world.puppeteerUtil`.
- setContext occurs but context is immediately destroyed, i.e.
`world.#puppeteerUtil === oldPromise` is not resolved.
- clearContext occurs due to destruction, i.e. `world.#puppeteerUtil` is
replaced (`world.#puppeteerUtil !== oldPromise`).
- `oldPromise` never resolves.
<!-- Thanks for submitting a pull request! Please provide enough
information so that others can review your pull request. -->
**What kind of change does this PR introduce?**
It changes the docs.
**Did you add tests for your changes?**
No.
**If relevant, did you update the documentation?**
Yes.
**Summary**
When logging the DevTools protocol traffic, the default value of
`maxStringLength` is 10000. Messages longer than that will be truncated.
This change adds an example to show how to remove the limitation with
`DEBUG_MAX_STRING_LENGTH=null`.
See https://nodejs.org/api/util.html#util_util_inspect_object_options.
**Does this PR introduce a breaking change?**
No.
**Other information**
None.
Bumps
[@angular-devkit/schematics](https://github.com/angular/angular-cli)
from 15.1.2 to 15.1.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/angular/angular-cli/releases"><code>@angular-devkit/schematics</code>'s
releases</a>.</em></p>
<blockquote>
<h2>v15.1.3</h2>
<p><!-- raw HTML omitted --><!-- raw HTML omitted --></p>
<h1>15.1.3 (2023-01-25)</h1>
<h3><code>@schematics/angular</code></h3>
<table>
<thead>
<tr>
<th>Commit</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td><a
href="2c04f4a8f4"><img
src="https://img.shields.io/badge/2c04f4a8f-fix-green" alt="fix -
2c04f4a8f" /></a></td>
<td>update browserslist config to include last 2 Chrome version</td>
</tr>
</tbody>
</table>
<h3><code>@angular/cli</code></h3>
<table>
<thead>
<tr>
<th>Commit</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td><a
href="de15ec5763"><img
src="https://img.shields.io/badge/de15ec576-fix-green" alt="fix -
de15ec576" /></a></td>
<td>handle extended schematics when retrieving aliases</td>
</tr>
</tbody>
</table>
<h3><code>@angular-devkit/build-angular</code></h3>
<table>
<thead>
<tr>
<th>Commit</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td><a
href="f31bf300b9"><img
src="https://img.shields.io/badge/f31bf300b-fix-green" alt="fix -
f31bf300b" /></a></td>
<td>avoid undefined module path for Sass imports in esbuild</td>
</tr>
<tr>
<td><a
href="c152a4a13f"><img
src="https://img.shields.io/badge/c152a4a13-fix-green" alt="fix -
c152a4a13" /></a></td>
<td>update browserslist config to include last 2 Chrome versions</td>
</tr>
</tbody>
</table>
<h3><code>@angular-devkit/core</code></h3>
<table>
<thead>
<tr>
<th>Commit</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td><a
href="9de99202e9"><img
src="https://img.shields.io/badge/9de99202e-fix-green" alt="fix -
9de99202e" /></a></td>
<td>handle number like strings in workspace writer</td>
</tr>
</tbody>
</table>
<h2>Special Thanks</h2>
<p>Alan Agius, Charles Lyding and Doug Parker</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/angular/angular-cli/blob/main/CHANGELOG.md"><code>@angular-devkit/schematics</code>'s
changelog</a>.</em></p>
<blockquote>
<h1>15.1.3 (2023-01-25)</h1>
<h3><code>@angular/cli</code></h3>
<table>
<thead>
<tr>
<th>Commit</th>
<th>Type</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td><a
href="de15ec5763">de15ec576</a></td>
<td>fix</td>
<td>handle extended schematics when retrieving aliases</td>
</tr>
</tbody>
</table>
<h3><code>@schematics/angular</code></h3>
<table>
<thead>
<tr>
<th>Commit</th>
<th>Type</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td><a
href="2c04f4a8f4">2c04f4a8f</a></td>
<td>fix</td>
<td>update browserslist config to include last 2 Chrome version</td>
</tr>
</tbody>
</table>
<h3><code>@angular-devkit/build-angular</code></h3>
<table>
<thead>
<tr>
<th>Commit</th>
<th>Type</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td><a
href="f31bf300b9">f31bf300b</a></td>
<td>fix</td>
<td>avoid undefined module path for Sass imports in esbuild</td>
</tr>
<tr>
<td><a
href="c152a4a13f">c152a4a13</a></td>
<td>fix</td>
<td>update browserslist config to include last 2 Chrome versions</td>
</tr>
</tbody>
</table>
<h3><code>@angular-devkit/core</code></h3>
<table>
<thead>
<tr>
<th>Commit</th>
<th>Type</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td><a
href="9de99202e9">9de99202e</a></td>
<td>fix</td>
<td>handle number like strings in workspace writer</td>
</tr>
</tbody>
</table>
<h2>Special Thanks</h2>
<p>Alan Agius, Charles Lyding and Doug Parker</p>
<!-- raw HTML omitted -->
<p><!-- raw HTML omitted --><!-- raw HTML omitted --></p>
<h1>15.2.0-next.1 (2023-01-18)</h1>
<h3><code>@angular/cli</code></h3>
<table>
<thead>
<tr>
<th>Commit</th>
<th>Type</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td><a
href="3ebb195525">3ebb19552</a></td>
<td>fix</td>
<td>register schematic aliases when providing collection name in
<code>ng generate</code></td>
</tr>
<tr>
<td><a
href="697df4f6e5">697df4f6e</a></td>
<td>fix</td>
<td>remove <code>--to</code> option from being required when using
<code>--from</code> in <code>ng update</code></td>
</tr>
</tbody>
</table>
<h3><code>@schematics/angular</code></h3>
<table>
<thead>
<tr>
<th>Commit</th>
<th>Type</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td><a
href="c8a3b30000">c8a3b3000</a></td>
<td>fix</td>
<td>replace existing <code>BrowserModule.withServerTransition</code>
calls when running universal schematic</td>
</tr>
</tbody>
</table>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="b27ce5da26"><code>b27ce5d</code></a>
release: cut the v15.1.3 release</li>
<li><a
href="3c459c3f68"><code>3c459c3</code></a>
build: update bazel aspect lib to 1.23.3</li>
<li><a
href="e293cb1a33"><code>e293cb1</code></a>
docs(<code>@angular/cli</code>): minor updates to <code>ng run</code>
description</li>
<li><a
href="2c04f4a8f4"><code>2c04f4a</code></a>
fix(<code>@schematics/angular</code>): update browserslist config to
include last 2 Chrome...</li>
<li><a
href="c152a4a13f"><code>c152a4a</code></a>
fix(<code>@angular-devkit/build-angular</code>): update browserslist
config to include las...</li>
<li><a
href="9de99202e9"><code>9de9920</code></a>
fix(<code>@angular-devkit/core</code>): handle number like strings in
workspace writer</li>
<li><a
href="f31bf300b9"><code>f31bf30</code></a>
fix(<code>@angular-devkit/build-angular</code>): avoid undefined module
path for Sass impo...</li>
<li><a
href="de15ec5763"><code>de15ec5</code></a>
fix(<code>@angular/cli</code>): handle extended schematics when
retrieving aliases</li>
<li><a
href="3661b3031d"><code>3661b30</code></a>
Revert "refactor: temporaily disable sending analytics"</li>
<li>See full diff in <a
href="https://github.com/angular/angular-cli/compare/15.1.2...15.1.3">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from
0.7.32 to 0.7.33.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/faisalman/ua-parser-js/blob/master/changelog.md">ua-parser-js's
changelog</a>.</em></p>
<blockquote>
<h2>Version 0.7.32 / 1.0.32</h2>
<ul>
<li>Add new browser : DuckDuckGo, Huawei Browser, LinkedIn</li>
<li>Add new OS : HarmonyOS</li>
<li>Add some Huawei models</li>
<li>Add Sharp Aquos TV</li>
<li>Improve detection Xiaomi Mi CC9</li>
<li>Fix Sony Xperia 1 III misidentified as Acer tablet</li>
<li>Fix Detect Sony BRAVIA as SmartTV</li>
<li>Fix Detect Xiaomi Mi TV as SmartTV</li>
<li>Fix Detect Galaxy Tab S8 as tablet</li>
<li>Fix WeGame mistakenly identified as WeChat</li>
<li>Fix included commas in Safari / Mobile Safari version</li>
<li>Increase UA_MAX_LENGTH to 350</li>
</ul>
<h2>Version 0.7.33 / 1.0.33</h2>
<ul>
<li>Add new browser : Cobalt</li>
<li>Identify Macintosh as an Apple device</li>
<li>Fix ReDoS vulnerability</li>
</ul>
<h1>Version 0.8</h1>
<p>Version 0.8 was created by accident. This version is now deprecated
and no longer maintained, please update to version 0.7 / 1.0.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="f2d0db001d"><code>f2d0db0</code></a>
Bump version 0.7.33</li>
<li><a
href="a6140a17dd"><code>a6140a1</code></a>
Remove unsafe regex in trim() function</li>
<li><a
href="a886604935"><code>a886604</code></a>
Fix <a
href="https://github-redirect.dependabot.com/faisalman/ua-parser-js/issues/605">#605</a>
- Identify Macintosh as Apple device</li>
<li><a
href="b814bcd791"><code>b814bcd</code></a>
Merge pull request <a
href="https://github-redirect.dependabot.com/faisalman/ua-parser-js/issues/606">#606</a>
from rileyjshaw/patch-1</li>
<li><a
href="7f71024161"><code>7f71024</code></a>
Fix documentation</li>
<li><a
href="c239ac5167"><code>c239ac5</code></a>
Merge pull request <a
href="https://github-redirect.dependabot.com/faisalman/ua-parser-js/issues/604">#604</a>
from obecerra3/master</li>
<li><a
href="8d3c2d327c"><code>8d3c2d3</code></a>
Add new browser: Cobalt</li>
<li>See full diff in <a
href="https://github.com/faisalman/ua-parser-js/compare/0.7.32...0.7.33">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/puppeteer/puppeteer/network/alerts).
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Since we moved to the central binaries cache it does not make sense to
clean up old binaries automatically because multiple installations can
use different versions. We expect the users to clean the cache from time
to time until we offer a CLI for managing the browsers.
Closes#9533
<!-- Thanks for submitting a pull request! Please provide enough
information so that others can review your pull request. -->
**What kind of change does this PR introduce?**
Test expectation file update
**Did you add tests for your changes?**
no
**Summary**
Unskippes tests for Firefox and linux, which were missed in the previous
update
**Does this PR introduce a breaking change?**
no
Issue: #9394
**What kind of change does this PR introduce?**
Feature - Added support of the `referrerPolicy` parameter (from CDP's
`Page.navigate`) to Puppeteer's `page.goto`.
**Did you add tests for your changes?**
No, currently it has no meaning that isn't browser implementation based,
which might get broken in the future. If there are suggestions to tests,
please let me know so I'll add them.
**If relevant, did you update the documentation?**
Yes, the documentation of the `goto` method has been updated.
**Summary**
I wanted to contribute to this project, which I used for testing on our
environment and saw issue #9394, so I decided to resolve it :)
**Does this PR introduce a breaking change?**
No. I added the `referrerPolicy` as an optional parameter, which will
use the HTTP header `Referrer-Policy` if not provided (much like the
`referer` parameter) so it will not interfere.
Co-authored-by: Ophir Back <ophir.back@broadcom.com>
What kind of change does this PR introduce?
Test expectation file update
Summary
Closes https://github.com/puppeteer/puppeteer/issues/9118.
This PR updates the test expectation file with more specific status for
firefox (like fail, fail-pass), removes the duplications.
Does this PR introduce a breaking change?
no
Bumps
[@angular-devkit/schematics](https://github.com/angular/angular-cli)
from 15.1.1 to 15.1.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/angular/angular-cli/releases"><code>@angular-devkit/schematics</code>'s
releases</a>.</em></p>
<blockquote>
<h2>v15.1.2</h2>
<p><!-- raw HTML omitted --><!-- raw HTML omitted --></p>
<h1>15.1.2 (2023-01-18)</h1>
<h3><code>@schematics/angular</code></h3>
<table>
<thead>
<tr>
<th>Commit</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td><a
href="0f5fb7e594"><img
src="https://img.shields.io/badge/0f5fb7e59-fix-green" alt="fix -
0f5fb7e59" /></a></td>
<td>replace existing <code>BrowserModule.withServerTransition</code>
calls when running universal schematic</td>
</tr>
</tbody>
</table>
<h3><code>@angular/cli</code></h3>
<table>
<thead>
<tr>
<th>Commit</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td><a
href="387472a956"><img
src="https://img.shields.io/badge/387472a95-fix-green" alt="fix -
387472a95" /></a></td>
<td>register schematic aliases when providing collection name in
<code>ng generate</code></td>
</tr>
<tr>
<td><a
href="5d9fd788a9"><img
src="https://img.shields.io/badge/5d9fd788a-fix-green" alt="fix -
5d9fd788a" /></a></td>
<td>remove <code>--to</code> option from being required when using
<code>--from</code> in <code>ng update</code></td>
</tr>
</tbody>
</table>
<h3><code>@angular-devkit/build-angular</code></h3>
<table>
<thead>
<tr>
<th>Commit</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td><a
href="bf4639a6e9"><img
src="https://img.shields.io/badge/bf4639a6e-fix-green" alt="fix -
bf4639a6e" /></a></td>
<td>prevent hanging initial build during exception with esbuild</td>
</tr>
</tbody>
</table>
<h2>Special Thanks</h2>
<p>Alan Agius, Charles Lyding and Doug Parker</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/angular/angular-cli/blob/main/CHANGELOG.md"><code>@angular-devkit/schematics</code>'s
changelog</a>.</em></p>
<blockquote>
<h1>15.1.2 (2023-01-18)</h1>
<h3><code>@angular/cli</code></h3>
<table>
<thead>
<tr>
<th>Commit</th>
<th>Type</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td><a
href="387472a956">387472a95</a></td>
<td>fix</td>
<td>register schematic aliases when providing collection name in
<code>ng generate</code></td>
</tr>
<tr>
<td><a
href="5d9fd788a9">5d9fd788a</a></td>
<td>fix</td>
<td>remove <code>--to</code> option from being required when using
<code>--from</code> in <code>ng update</code></td>
</tr>
</tbody>
</table>
<h3><code>@schematics/angular</code></h3>
<table>
<thead>
<tr>
<th>Commit</th>
<th>Type</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td><a
href="0f5fb7e594">0f5fb7e59</a></td>
<td>fix</td>
<td>replace existing <code>BrowserModule.withServerTransition</code>
calls when running universal schematic</td>
</tr>
</tbody>
</table>
<h3><code>@angular-devkit/build-angular</code></h3>
<table>
<thead>
<tr>
<th>Commit</th>
<th>Type</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td><a
href="bf4639a6e9">bf4639a6e</a></td>
<td>fix</td>
<td>prevent hanging initial build during exception with esbuild</td>
</tr>
</tbody>
</table>
<h2>Special Thanks</h2>
<p>Alan Agius, Charles Lyding and Doug Parker</p>
<!-- raw HTML omitted -->
<p><!-- raw HTML omitted --><!-- raw HTML omitted --></p>
<h1>15.2.0-next.0 (2023-01-12)</h1>
<h3><code>@angular-devkit/build-angular</code></h3>
<table>
<thead>
<tr>
<th>Commit</th>
<th>Type</th>
<th>Description</th>
</tr>
</thead>
<tbody>
<tr>
<td><a
href="09af707438">09af70743</a></td>
<td>feat</td>
<td>implement node module license extraction for esbuild builder</td>
</tr>
</tbody>
</table>
<h2>Special Thanks</h2>
<p>Alan Agius and Charles Lyding</p>
<!-- raw HTML omitted -->
<p><!-- raw HTML omitted --><!-- raw HTML omitted --></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="97b443b2fd"><code>97b443b</code></a>
release: cut the v15.1.2 release</li>
<li><a
href="0f5fb7e594"><code>0f5fb7e</code></a>
fix(<code>@schematics/angular</code>): replace existing
`BrowserModule.withServerTransitio...</li>
<li><a
href="bc5555ca3c"><code>bc5555c</code></a>
refactor: only collect Node version if it's a standard version
string</li>
<li><a
href="bf4639a6e9"><code>bf4639a</code></a>
fix(<code>@angular-devkit/build-angular</code>): prevent hanging
initial build during exce...</li>
<li><a
href="387472a956"><code>387472a</code></a>
fix(<code>@angular/cli</code>): register schematic aliases when
providing collection name ...</li>
<li><a
href="b0004817c5"><code>b000481</code></a>
build: update dev-infra packages</li>
<li><a
href="5d9fd788a9"><code>5d9fd78</code></a>
fix(<code>@angular/cli</code>): remove <code>--to</code> option from
being required when using `--fro...</li>
<li><a
href="9fa5f2ce0c"><code>9fa5f2c</code></a>
refactor(<code>@angular-devkit/build-angular</code>): remove direct
import of i18n worker ...</li>
<li><a
href="4b594992e9"><code>4b59499</code></a>
build: update dependency ng-packagr to v15.1.1</li>
<li>See full diff in <a
href="https://github.com/angular/angular-cli/compare/15.1.1...15.1.2">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The third_party folder is compiled with tsc and then rolled up in-place.
This means that the next build might try to compile the file that has
been rolled up leading to build errors. It seems the safest solution is
to always rebuild third_party folder as the size is relatively small.
