ede43ca2d3
Using RxJS greatly simplifies the control flow for locators and comes with automatic cleanup on failure. It greatly simplifies the `signal` logic and the retry logic. |
||
|---|---|---|
| .. | ||
| mitt | ||
| rxjs | ||
| README.md | ||
| tsconfig.cjs.json | ||
| tsconfig.json | ||
third_party
This folder contains code that interacts with third party node modules that will be vendored with puppeteer during publishing.
Why not node_modules?
Because we are working towards an agnostic Puppeteer that can run in any
environment (see #6125) we
cannot import common dependencies in a way that relies on Node's resolution to
find them. For example, import mitt from 'mitt' works fine in Node, but in an
ESM build running in an environment without module resolution such as the
browser, 'mitt' would not make sense.
The process for installing/using a vendored dependency is a two-step process:
- Create a folder named after the package. See the
node_modulesfolder for inspiration. - Create an entrypoint that exports needed imports from the package. For
example,
index.tsmay contain
export * from 'your-package';
export {default as default} from 'your-package';
Now if you need to import from the dependency, you need to import relative to this directory rather than the package name itself.