28797dee41
This CL migrates all the tests to TypeScript. The main benefits of this is that we start consuming our TypeScript definitions and therefore find errors in them. The act of migrating found some bugs in our definitions and now we can be sure to avoid them going forwards. You'll notice the addition of some `TODO`s in the code; I didn't want this CL to get any bigger than it already is but I intend to follow those up once this lands. It's mostly figuring out how to extend the `expect` types with our `toBeGolden` helpers and some other slight confusions with types that the tests exposed. Co-authored-by: Mathias Bynens <mathias@qiwi.be>
94 lines
3.3 KiB
TypeScript
94 lines
3.3 KiB
TypeScript
/**
|
|
* Copyright 2019 Google Inc. All rights reserved.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
/* eslint-disable @typescript-eslint/no-var-requires */
|
|
|
|
import expect from 'expect';
|
|
import { getTestState, itChromeOnly } from './mocha-utils';
|
|
|
|
import path from 'path';
|
|
|
|
describe('Fixtures', function () {
|
|
itChromeOnly('dumpio option should work with pipe option ', async () => {
|
|
const { defaultBrowserOptions, puppeteerPath } = getTestState();
|
|
|
|
let dumpioData = '';
|
|
const { spawn } = require('child_process');
|
|
const options = Object.assign({}, defaultBrowserOptions, {
|
|
pipe: true,
|
|
dumpio: true,
|
|
});
|
|
const res = spawn('node', [
|
|
path.join(__dirname, 'fixtures', 'dumpio.js'),
|
|
puppeteerPath,
|
|
JSON.stringify(options),
|
|
]);
|
|
res.stderr.on('data', (data) => (dumpioData += data.toString('utf8')));
|
|
await new Promise((resolve) => res.on('close', resolve));
|
|
expect(dumpioData).toContain('message from dumpio');
|
|
});
|
|
it('should dump browser process stderr', async () => {
|
|
const { defaultBrowserOptions, puppeteerPath } = getTestState();
|
|
|
|
let dumpioData = '';
|
|
const { spawn } = require('child_process');
|
|
const options = Object.assign({}, defaultBrowserOptions, { dumpio: true });
|
|
const res = spawn('node', [
|
|
path.join(__dirname, 'fixtures', 'dumpio.js'),
|
|
puppeteerPath,
|
|
JSON.stringify(options),
|
|
]);
|
|
res.stderr.on('data', (data) => (dumpioData += data.toString('utf8')));
|
|
await new Promise((resolve) => res.on('close', resolve));
|
|
expect(dumpioData).toContain('DevTools listening on ws://');
|
|
});
|
|
it('should close the browser when the node process closes', async () => {
|
|
const { defaultBrowserOptions, puppeteerPath, puppeteer } = getTestState();
|
|
|
|
const { spawn, execSync } = require('child_process');
|
|
const options = Object.assign({}, defaultBrowserOptions, {
|
|
// Disable DUMPIO to cleanly read stdout.
|
|
dumpio: false,
|
|
});
|
|
const res = spawn('node', [
|
|
path.join(__dirname, 'fixtures', 'closeme.js'),
|
|
puppeteerPath,
|
|
JSON.stringify(options),
|
|
]);
|
|
let wsEndPointCallback;
|
|
const wsEndPointPromise = new Promise<string>(
|
|
(x) => (wsEndPointCallback = x)
|
|
);
|
|
let output = '';
|
|
res.stdout.on('data', (data) => {
|
|
output += data;
|
|
if (output.indexOf('\n'))
|
|
wsEndPointCallback(output.substring(0, output.indexOf('\n')));
|
|
});
|
|
const browser = await puppeteer.connect({
|
|
browserWSEndpoint: await wsEndPointPromise,
|
|
});
|
|
const promises = [
|
|
new Promise((resolve) => browser.once('disconnected', resolve)),
|
|
new Promise((resolve) => res.on('close', resolve)),
|
|
];
|
|
if (process.platform === 'win32')
|
|
execSync(`taskkill /pid ${res.pid} /T /F`);
|
|
else process.kill(res.pid);
|
|
await Promise.all(promises);
|
|
});
|
|
});
|