puppeteer/lib
Andrey Lushnikov b73737302a
fix: convert all getters to methods (#1621)
The patch converts all the getters in the codebase into the methods.
For example, the `request.url` getter becomes the `request.url()`
method.

This is done in order to unify the API and make it more predictable.
The general rule for all further changes would be:
- there are no getters/fields exposed in the api
- the only exceptions are "namespaces", e.g. `page.keyboard`

Fixes #280.

BREAKING CHANGE:
This patch ditches getters and replaces them with methods throughout
the API. The following methods were added instead of the fields:
- dialog.type()
- consoleMessage.args()
- consoleMessage.text()
- consoleMessage.type()
- request.headers()
- request.method()
- request.postData()
- request.resourceType()
- request.url()
- response.headers()
- response.ok()
- response.status()
- response.url()
2017-12-18 17:05:57 -08:00
..
.eslintrc.js Introduce Eslint to validate style 2017-06-11 01:32:59 -07:00
Browser.js feat(Browser): introduce browser.process() variable (#1581) 2017-12-11 12:11:12 -08:00
Connection.js feat(Connection): nicer stack traces on protocol errors (#1383) 2017-12-08 19:05:46 -08:00
Dialog.js fix: convert all getters to methods (#1621) 2017-12-18 17:05:57 -08:00
Downloader.js chore: generalize node6 transpilation (#1560) 2017-12-08 15:14:28 -08:00
ElementHandle.js fix(ElementHandle.screenshot): account for scroll (#1323) 2017-11-10 16:02:52 -08:00
EmulationManager.js chore: Use Typescript to lint JSDoc annotations (#986) 2017-10-09 22:31:40 -07:00
ExecutionContext.js fix(Frame): postpone evaluations until execution context gets created (#1415) 2017-11-18 16:27:52 -08:00
externs.d.ts chore: Use Typescript to lint JSDoc annotations (#986) 2017-10-09 22:31:40 -07:00
FrameManager.js feat(Frame): implement frame.content and frame.setContent methods (#1447) 2017-11-23 05:44:33 +03:00
helper.js fix: Remove synchronous operation with file system. (#879) 2017-10-11 00:55:48 -07:00
Input.js fix(touch): requestAnimationFrame before sending tap (#1142) 2017-10-26 14:53:50 -07:00
Launcher.js feat(Browser): introduce browser.process() variable (#1581) 2017-12-11 12:11:12 -08:00
Multimap.js chore: Use Typescript to lint JSDoc annotations (#986) 2017-10-09 22:31:40 -07:00
NavigatorWatcher.js fix(page): fix "timeout: 0" to actually disable any navigation timeout (#1435) 2017-11-21 08:21:25 +03:00
NetworkManager.js fix: convert all getters to methods (#1621) 2017-12-18 17:05:57 -08:00
Page.js fix: convert all getters to methods (#1621) 2017-12-18 17:05:57 -08:00
Puppeteer.js chore: Use Typescript to lint JSDoc annotations (#986) 2017-10-09 22:31:40 -07:00
Tracing.js feat(Tracing): allow custom tracing categories (#1439) 2017-12-03 18:36:34 -08:00
USKeyboardLayout.js feat(keyboard): Accept codes (#1116) 2017-10-23 12:43:45 -07:00