thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
d9bb7ee8a0
puppeteer/lib
History
Ran Yitzhaki 8fce3195d6 fix(Launcher): exit the process after killing chrome on SIGINT (#2428) 
This is a fix for this issue https://github.com/facebook/jest/issues/5748

In the issue, `puppeteer.launch` method is called from jest `globalSetup` script which [is running on the same process as jest](6a77ee37ec/packages/jest-cli/src/run_jest.js (L242)).

Puppeteer catches `SIGINT` in order to kill chrome, but it also replaces the default behaviour of `SIGINT`, [which is to exit with status code 130](https://nodejs.org/dist/latest-v9.x/docs/api/all.html#process_signal_events). In jest's case, the process does not exit, which keeps the process hanging in a weird way.

This PR makes sure that the process exits after killing chrome.
2018-04-25 15:29:14 -07:00
..
.eslintrc.js Introduce Eslint to validate style 2017-06-11 01:32:59 -07:00
Browser.js Add Page.browser() method (#2387) 2018-04-17 10:37:17 -07:00
BrowserFetcher.js fix(BrowserFetcher): ensure executable has proper permissions (#2342) 2018-04-10 14:11:59 -07:00
Connection.js fix(Connection): do not assert that methods always have callbacks. (#2330) 2018-04-07 17:59:22 -07:00
Coverage.js chore(types): type check the rest of the protocol (#2328) 2018-04-07 17:58:52 -07:00
Dialog.js feat: expose raw devtools protocol connection (#1770) 2018-01-10 19:33:22 -08:00
ElementHandle.js chore(types): type check the rest of the protocol (#2328) 2018-04-07 17:58:52 -07:00
EmulationManager.js chore(types): type check the rest of the protocol (#2328) 2018-04-07 17:58:52 -07:00
ExecutionContext.js fix(Page): fix Page.evaluate with Symbols in arrays (#2340) 2018-04-09 22:02:35 -07:00
externs.d.ts chore(types): type check the rest of the protocol (#2328) 2018-04-07 17:58:52 -07:00
FrameManager.js fix(Page): Page.waitForNavigation should correctly handle mixed content (#2339) 2018-04-10 15:59:41 -07:00
helper.js chore(types): generate a d.ts file for protocol types (#2325) 2018-04-06 18:20:48 -07:00
Input.js Fix: Remove key codes from _pressedKeys Set after keyboard.up() is called (#1928) 2018-02-12 17:25:38 -08:00
Launcher.js fix(Launcher): exit the process after killing chrome on SIGINT (#2428) 2018-04-25 15:29:14 -07:00
Multimap.js chore: Use Typescript to lint JSDoc annotations (#986) 2017-10-09 22:31:40 -07:00
NavigatorWatcher.js fix(Page): support anchor navigation (#2338) 2018-04-09 23:38:20 -07:00
NetworkManager.js fix(Network): explicitly throw on content request for redirect response (#2352) 2018-04-10 20:22:18 -07:00
Page.js chore(deps): bump dependencies (#2397) 2018-04-17 14:51:03 -07:00
Pipe.js feat(appMode): support pipes for appMode (#2032) 2018-02-14 17:51:29 -08:00
Puppeteer.js chore(types): upgrade to TypeScript 2.8.1 (#2304) 2018-04-04 14:06:21 -07:00
Target.js Add Page.browser() method (#2387) 2018-04-17 10:37:17 -07:00
TaskQueue.js chore: refactor Browser.js into seperate files (#2097) 2018-02-26 12:10:06 -08:00
Tracing.js Chore: replace depracated 'new Buffer' with 'Buffer.from' (#2396) 2018-04-17 13:49:01 -07:00
USKeyboardLayout.js feat(keyboard): Accept codes (#1116) 2017-10-23 12:43:45 -07:00