f666be3f5f
Now the async hooks helper is gone api.ts was only used by the coverage tools and by doclint. DocLint is nearing the end of its lifespan with the TSDoc work, so I focused on how best to define a list of modules for the coverage tooling. They define an object of classes, and the path to that module. They need the full path because we also check if the module exports any events that need to be emitted - the coverage tool asserts that the emitting of those events is also tested. It's not _great_ that DocLint relies on a constant defined in the coverage utils, but it should only be this way for a short period of time and no one is actively working on DocLint (bar the effort to remove it) so I don't think this is worth worrying about. This change also broke the DocLint tests; based on the fact that DocLint is on its way out it doesn't feel worth fixing the tests, so this commit also removes them.
164 lines
5.4 KiB
JavaScript
164 lines
5.4 KiB
JavaScript
/**
|
|
* Copyright 2020 Google Inc. All rights reserved.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
// TODO (@jackfranklin): convert this to TypeScript and enable type-checking
|
|
// @ts-nocheck
|
|
|
|
/* We want to ensure that all of Puppeteer's public API is tested via our unit
|
|
* tests but we can't use a tool like Istanbul because the way it instruments
|
|
* code unfortunately breaks in Puppeteer where some of that code is then being
|
|
* executed in a browser context.
|
|
*
|
|
* So instead we maintain this coverage code which does the following:
|
|
* * takes every public method that we expect to be tested
|
|
* * replaces it with a method that calls the original but also updates a Map of calls
|
|
* * in an after() test callback it asserts that every public method was called.
|
|
*
|
|
* We run this when COVERAGE=1.
|
|
*/
|
|
|
|
const path = require('path');
|
|
const fs = require('fs');
|
|
|
|
/**
|
|
* This object is also used by DocLint to know which classes to check are
|
|
* documented. It's a pretty hacky solution but DocLint is going away soon as
|
|
* part of the TSDoc migration.
|
|
*/
|
|
const MODULES_TO_CHECK_FOR_COVERAGE = {
|
|
Accessibility: '../src/common/Accessibility',
|
|
Browser: '../src/common/Browser',
|
|
BrowserContext: '../src/common/Browser',
|
|
BrowserFetcher: '../src/node/BrowserFetcher',
|
|
CDPSession: '../src/common/Connection',
|
|
ConsoleMessage: '../src/common/ConsoleMessage',
|
|
Coverage: '../src/common/Coverage',
|
|
Dialog: '../src/common/Dialog',
|
|
ElementHandle: '../src/common/JSHandle',
|
|
ExecutionContext: '../src/common/ExecutionContext',
|
|
EventEmitter: '../src/common/EventEmitter',
|
|
FileChooser: '../src/common/FileChooser',
|
|
Frame: '../src/common/FrameManager',
|
|
JSHandle: '../src/common/JSHandle',
|
|
Keyboard: '../src/common/Input',
|
|
Mouse: '../src/common/Input',
|
|
Page: '../src/common/Page',
|
|
Puppeteer: '../src/common/Puppeteer',
|
|
HTTPRequest: '../src/common/HTTPRequest',
|
|
HTTPResponse: '../src/common/HTTPResponse',
|
|
SecurityDetails: '../src/common/SecurityDetails',
|
|
Target: '../src/common/Target',
|
|
TimeoutError: '../src/common/Errors',
|
|
Touchscreen: '../src/common/Input',
|
|
Tracing: '../src/common/Tracing',
|
|
WebWorker: '../src/common/WebWorker',
|
|
};
|
|
|
|
function traceAPICoverage(apiCoverage, className, modulePath) {
|
|
const loadedModule = require(modulePath);
|
|
const classType = loadedModule[className];
|
|
|
|
if (!classType || !classType.prototype) {
|
|
console.error(
|
|
`Coverage error: could not find class for ${className}. Is src/api.ts up to date?`
|
|
);
|
|
process.exit(1);
|
|
}
|
|
for (const methodName of Reflect.ownKeys(classType.prototype)) {
|
|
const method = Reflect.get(classType.prototype, methodName);
|
|
if (
|
|
methodName === 'constructor' ||
|
|
typeof methodName !== 'string' ||
|
|
methodName.startsWith('_') ||
|
|
typeof method !== 'function'
|
|
)
|
|
continue;
|
|
apiCoverage.set(`${className}.${methodName}`, false);
|
|
Reflect.set(classType.prototype, methodName, function (...args) {
|
|
apiCoverage.set(`${className}.${methodName}`, true);
|
|
return method.call(this, ...args);
|
|
});
|
|
}
|
|
|
|
/**
|
|
* If classes emit events, those events are exposed via an object in the same
|
|
* module named XEmittedEvents, where X is the name of the class. For example,
|
|
* the Page module exposes PageEmittedEvents.
|
|
*/
|
|
const eventsName = `${className}EmittedEvents`;
|
|
if (loadedModule[eventsName]) {
|
|
for (const event of Object.values(loadedModule[eventsName])) {
|
|
if (typeof event !== 'symbol')
|
|
apiCoverage.set(`${className}.emit(${JSON.stringify(event)})`, false);
|
|
}
|
|
const method = Reflect.get(classType.prototype, 'emit');
|
|
Reflect.set(classType.prototype, 'emit', function (event, ...args) {
|
|
if (typeof event !== 'symbol' && this.listenerCount(event))
|
|
apiCoverage.set(`${className}.emit(${JSON.stringify(event)})`, true);
|
|
return method.call(this, event, ...args);
|
|
});
|
|
}
|
|
}
|
|
|
|
const coverageLocation = path.join(__dirname, 'coverage.json');
|
|
|
|
const clearOldCoverage = () => {
|
|
try {
|
|
fs.unlinkSync(coverageLocation);
|
|
} catch (error) {
|
|
// do nothing, the file didn't exist
|
|
}
|
|
};
|
|
const writeCoverage = (coverage) => {
|
|
fs.writeFileSync(coverageLocation, JSON.stringify([...coverage.entries()]));
|
|
};
|
|
|
|
const getCoverageResults = () => {
|
|
let contents;
|
|
try {
|
|
contents = fs.readFileSync(coverageLocation, { encoding: 'utf8' });
|
|
} catch (error) {
|
|
console.error('Warning: coverage file does not exist or is not readable.');
|
|
}
|
|
|
|
const coverageMap = new Map(JSON.parse(contents));
|
|
return coverageMap;
|
|
};
|
|
|
|
const trackCoverage = () => {
|
|
clearOldCoverage();
|
|
const coverageMap = new Map();
|
|
|
|
return {
|
|
beforeAll: () => {
|
|
for (const [className, moduleFilePath] of Object.entries(
|
|
MODULES_TO_CHECK_FOR_COVERAGE
|
|
)) {
|
|
traceAPICoverage(coverageMap, className, moduleFilePath);
|
|
}
|
|
},
|
|
afterAll: () => {
|
|
writeCoverage(coverageMap);
|
|
},
|
|
};
|
|
};
|
|
|
|
module.exports = {
|
|
trackCoverage,
|
|
getCoverageResults,
|
|
MODULES_TO_CHECK_FOR_COVERAGE,
|
|
};
|