From 41a78435075664a381eb0e12b9393ac8080354ff Mon Sep 17 00:00:00 2001
From: sigma-andex <77549848+sigma-andex@users.noreply.github.com>
Date: Sun, 21 Aug 2022 20:10:14 +0100
Subject: [PATCH] Add NodeMiddlewareStack

---
 src/HTTPurple/NodeMiddleware.purs |  6 ++++++
 src/HTTPurple/Request.purs        |  2 +-
 src/HTTPurple/Server.purs         | 24 ++++++++++++------------
 3 files changed, 19 insertions(+), 13 deletions(-)

diff --git a/src/HTTPurple/NodeMiddleware.purs b/src/HTTPurple/NodeMiddleware.purs
index f10fdf2..cfe0e84 100644
--- a/src/HTTPurple/NodeMiddleware.purs
+++ b/src/HTTPurple/NodeMiddleware.purs
@@ -81,3 +81,9 @@ callNext next = runEffectFn1 next (asOneOf $ undefined)
 
 callNextWithError :: EffectFn1 NextHandlerArg Unit -> Error -> Effect Unit
 callNextWithError next err = runEffectFn1 next (asOneOf err)
+
+newtype NodeMiddlewareStack :: Row Type -> Row Type -> Type
+newtype NodeMiddlewareStack input output =
+  NodeMiddlewareStack (MiddlewareResult input -> ContT (MiddlewareResult output) Effect (MiddlewareResult input))
+
+instance Newtype (NodeMiddlewareStack input output) (MiddlewareResult input -> ContT (MiddlewareResult output) Effect (MiddlewareResult input))
diff --git a/src/HTTPurple/Request.purs b/src/HTTPurple/Request.purs
index e78589b..5834e2a 100644
--- a/src/HTTPurple/Request.purs
+++ b/src/HTTPurple/Request.purs
@@ -97,7 +97,7 @@ fromHTTPRequest route request = do
     bitraverse (const $ mkRequest request unit) (mkRequest request)
 
 fromHTTPRequestUnit :: HTTP.Request -> Aff (Request Unit)
-fromHTTPRequestUnit request = mkRequest request unit
+fromHTTPRequestUnit = flip mkRequest unit
 
 fromHTTPRequestExt ::
   forall ctx ctxRL thru route.
diff --git a/src/HTTPurple/Server.purs b/src/HTTPurple/Server.purs
index f3dc48f..2e1726b 100644
--- a/src/HTTPurple/Server.purs
+++ b/src/HTTPurple/Server.purs
@@ -12,7 +12,7 @@ module HTTPurple.Server
 
 import Prelude
 
-import Control.Monad.Cont (ContT, runContT)
+import Control.Monad.Cont (runContT)
 import Data.Maybe (Maybe(..), fromMaybe)
 import Data.Options ((:=))
 import Data.Posix.Signal (Signal(..))
@@ -23,7 +23,7 @@ import Effect.Class (liftEffect)
 import Effect.Class.Console (log)
 import Effect.Console (error)
 import Effect.Exception (Error)
-import HTTPurple.NodeMiddleware (MiddlewareResult(..), NextInvocation(..))
+import HTTPurple.NodeMiddleware (MiddlewareResult(..), NextInvocation(..), NodeMiddlewareStack(..))
 import HTTPurple.Record.Extra as Extra
 import HTTPurple.Request (ExtRequest, Request, RequestR, fromHTTPRequest, fromHTTPRequestExt, fromHTTPRequestUnit)
 import HTTPurple.Response (Response, ResponseM, internalServerError, notFound, send)
@@ -78,13 +78,13 @@ type ExtRoutingSettingsR route output r =
   | r
   )
 
-type MiddlewareSettingsR :: forall k1 k2. k1 -> k2 -> Row Type
+type MiddlewareSettingsR :: Row Type -> Row Type -> Row Type
 type MiddlewareSettingsR input output =
-  ( middleware :: MiddlewareResult input -> ContT (MiddlewareResult output) Effect (MiddlewareResult input)
-  , middlewareErrorHandler :: Error -> Request Unit -> Aff Response
+  ( --middleware :: MiddlewareResult input -> ContT (MiddlewareResult output) Effect (MiddlewareResult input)
+  middleware :: NodeMiddlewareStack input output
   )
 
-type ExtRoutingSettings :: forall k. Type -> k -> Row Type -> Type
+type ExtRoutingSettings :: Type -> Row Type -> Row Type -> Type
 type ExtRoutingSettings route input output = { | ExtRoutingSettingsR route output + MiddlewareSettingsR input output }
 
 -- | Given a router, handle unhandled exceptions it raises by
@@ -153,22 +153,22 @@ handleExtRequestWithMiddleware ::
   Extra.Keys outputRL =>
   Nub (RequestR route output) (RequestR route output) =>
   { route :: RD.RouteDuplex' route
-  , middleware :: MiddlewareResult input -> ContT (MiddlewareResult output) Effect (MiddlewareResult input)
-  , middlewareErrorHandler :: Error -> Request Unit -> Aff Response
+  --, middleware :: MiddlewareResult input -> ContT (MiddlewareResult output) Effect (MiddlewareResult input)
+  , middleware :: NodeMiddlewareStack input output
   , router :: ExtRequest route output -> ResponseM
   , notFoundHandler :: Request Unit -> ResponseM
   } ->
   HTTP.Request ->
   HTTP.Response ->
   Effect Unit
-handleExtRequestWithMiddleware { route, middleware, middlewareErrorHandler, router, notFoundHandler } req resp = void $ runAff (\_ -> pure unit) $ do
+handleExtRequestWithMiddleware { route, middleware: NodeMiddlewareStack middleware, router, notFoundHandler } req resp = void $ runAff (\_ -> pure unit) $ do
   eff <- liftEffect $ flip runContT (coerce >>> pure) $ middleware (MiddlewareResult { request: req, response: resp, middlewareResult: NotCalled })
   executeHandler eff
   where
 
   executeHandler :: MiddlewareResult output -> Aff Unit
   executeHandler (MiddlewareResult { request, response, middlewareResult: ProcessingFailed error }) =
-    liftEffect $ handleRequestUnit (middlewareErrorHandler error) request response
+    liftEffect $ handleRequestUnit (defaultMiddlewareErrorHandler error) request response
   executeHandler (MiddlewareResult { request, response, middlewareResult: ProcessingSucceeded }) =
     handleExtRequest { route, router, notFoundHandler } request response
   executeHandler (MiddlewareResult { middlewareResult: NotCalled }) =
@@ -267,8 +267,8 @@ serveWithMiddleware inputOptions settings = do
 
     routingSettings ::
       { route :: RD.RouteDuplex' route
-      , middleware :: MiddlewareResult input -> ContT (MiddlewareResult output) Effect (MiddlewareResult input)
-      , middlewareErrorHandler :: Error -> Request Unit -> Aff Response
+      --, middleware :: MiddlewareResult input -> ContT (MiddlewareResult output) Effect (MiddlewareResult input)
+      , middleware :: NodeMiddlewareStack input output
       , router :: ExtRequest route output -> ResponseM
       , notFoundHandler :: Request Unit -> ResponseM
       }