Ensure correct ordering on stream operations (#176)

src/HTTPure/Body.purs

@@ -42,9 +42,10 @@ instance bodyString :: Body String where
     Aff.makeAff \done -> do
       let
         stream = HTTP.responseAsStream response
-      _ <- Stream.writeString stream Encoding.UTF8 body $ pure unit
+      void $ Stream.writeString stream Encoding.UTF8 body
-      _ <- Stream.end stream $ pure unit
+        $ Stream.end stream
-      done $ Either.Right unit
+        $ done
+        $ Either.Right unit
       pure Aff.nonCanceler
 
 -- | The instance for `Buffer` is trivial--we add a `Content-Length` header
@@ -56,9 +57,10 @@ instance bodyBuffer :: Body Buffer.Buffer where
     Aff.makeAff \done -> do
       let
         stream = HTTP.responseAsStream response
-      _ <- Stream.write stream body $ pure unit
+      void $ Stream.write stream body
-      _ <- Stream.end stream $ pure unit
+        $ Stream.end stream
-      done $ Either.Right unit
+        $ done
+        $ Either.Right unit
       pure Aff.nonCanceler
 
 -- | This instance can be used to send chunked data.  Here, we add a
@@ -72,7 +74,7 @@ instance bodyChunked ::
     Aff.makeAff \done -> do
       let
         stream = TypeEquals.to body
-      _ <- Stream.pipe stream $ HTTP.responseAsStream response
+      void $ Stream.pipe stream $ HTTP.responseAsStream response
       Stream.onEnd stream $ done $ Either.Right unit
       pure Aff.nonCanceler
 

test/Test/HTTPure/ResponseSpec.purs

@@ -45,9 +45,11 @@ sendSpec =
         \response ->
           Aff.makeAff \done -> do
             stream <- pure $ HTTP.responseAsStream response
-            _ <- Stream.writeString stream Encoding.UTF8 "test" $ pure unit
+            void
-            _ <- Stream.end stream $ pure unit
+              $ Stream.writeString stream Encoding.UTF8 "test"
-            done $ Either.Right unit
+              $ Stream.end stream
+              $ done
+              $ Either.Right unit
             pure Aff.nonCanceler
     }
 

test/Test/HTTPure/TestHelpers.js

@@ -30,11 +30,19 @@ exports.mockResponse = function() {
     body: "",
     headers: {},
 
-    write: function(str) {
+    write: function(str, encoding, callback) {
       this.body = this.body + str;
+      if (callback) {
+        callback();
+      }
+    },
+
+    end: function(str, encoding, callback) {
+      if (callback) {
+        callback();
+      }
     },
 
-    end: function() { },
     on: function() { },
     once: function() { },
     emit: function() { },

test/Test/HTTPure/TestHelpers.purs

@@ -47,8 +47,10 @@ request secure port method headers path body =
     req <- HTTPClient.request options $ Either.Right >>> done
     let
       stream = HTTPClient.requestAsStream req
-    _ <- Stream.writeString stream Encoding.UTF8 body $ pure unit
+    void
-    Stream.end stream $ pure unit
+      $ Stream.writeString stream Encoding.UTF8 body
+      $ Stream.end stream
+      $ pure unit
     pure Aff.nonCanceler
   where
   options =