github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: fix the window.stop test (#12526)

Browse Source
This commit is contained in:
Alex Rudenko 2024-06-03 15:27:18 +02:00 committed by GitHub
parent 0fd7530cbc
commit 26d800cae8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/TestExpectations.json
View File

@ -2379,19 +2379,12 @@
"expectations": ["SKIP"], "expectations": ["SKIP"],
"comment": "TODO: add a comment explaining why this expectation is required (include links to issues)" "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
}, },
{
"testIdPattern": "[navigation.spec] navigation Page.waitForNavigation should work when subframe issues window.stop()",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["firefox", "webDriverBiDi"],
"expectations": ["SKIP"],
"comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
},
{ {
"testIdPattern": "[navigation.spec] navigation Page.waitForNavigation should work when subframe issues window.stop()", "testIdPattern": "[navigation.spec] navigation Page.waitForNavigation should work when subframe issues window.stop()",
"platforms": ["darwin", "linux", "win32"], "platforms": ["darwin", "linux", "win32"],
"parameters": ["chrome", "webDriverBiDi"], "parameters": ["chrome", "webDriverBiDi"],
"expectations": ["SKIP"], "expectations": ["SKIP"],
"comment": "TODO: add a comment explaining why this expectation is required (include links to issues)" "comment": "TODO: evaluating in the frame that was just attached causes an error in chromium-bidi"
}, },
{ {
"testIdPattern": "[navigation.spec] navigation Page.waitForNavigation should work with DOM history.back()/history.forward()", "testIdPattern": "[navigation.spec] navigation Page.waitForNavigation should work with DOM history.back()/history.forward()",

3
test/src/navigation.spec.ts
View File

@ -719,9 +719,6 @@ describe('navigation', function () {
waitEvent(page, 'frameattached').then(_frame => { waitEvent(page, 'frameattached').then(_frame => {
return (frame = _frame); return (frame = _frame);
}), }),
waitEvent(page, 'framenavigated', f => {
return f === frame;
}),
]), ]),
Deferred.create({ Deferred.create({
message: `should work when subframe issues window.stop()`, message: `should work when subframe issues window.stop()`,