chore: small fixes (#11397)

This commit is contained in:
Nikolay Vitkov 2023-11-16 08:16:40 +01:00 committed by GitHub
parent 856802fec3
commit b58ba6b07c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 10 additions and 3 deletions

View File

@ -53,3 +53,4 @@ versioned_*/
# Ng-schematics # Ng-schematics
/packages/ng-schematics/files/ /packages/ng-schematics/files/
/packages/ng-schematics/sandbox/ /packages/ng-schematics/sandbox/
/packages/ng-schematics/multi/

View File

@ -1356,7 +1356,6 @@ export abstract class ElementHandle<
const page = this.frame.page(); const page = this.frame.page();
// eslint-disable-next-line @typescript-eslint/no-unused-vars
await using _ = await using _ =
allowViewportExpansion && clip allowViewportExpansion && clip
? await page._createTemporaryViewportContainingBox(clip) ? await page._createTemporaryViewportContainingBox(clip)

View File

@ -162,7 +162,6 @@ export class IsolatedWorld extends Realm {
return; return;
} }
// eslint-disable-next-line @typescript-eslint/no-unused-vars
using _ = await this.#mutex.acquire(); using _ = await this.#mutex.acquire();
try { try {
await context._client.send( await context._client.send(

View File

@ -3635,6 +3635,12 @@
"parameters": ["firefox", "headful", "webDriverBiDi"], "parameters": ["firefox", "headful", "webDriverBiDi"],
"expectations": ["FAIL"] "expectations": ["FAIL"]
}, },
{
"testIdPattern": "[launcher.spec] Launcher specs Puppeteer Browser.disconnect should reject navigation when browser closes",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["cdp", "firefox", "headful"],
"expectations": ["FAIL", "PASS"]
},
{ {
"testIdPattern": "[navigation.spec] navigation \"after all\" hook in \"navigation\"", "testIdPattern": "[navigation.spec] navigation \"after all\" hook in \"navigation\"",
"platforms": ["darwin", "linux", "win32"], "platforms": ["darwin", "linux", "win32"],

View File

@ -203,6 +203,8 @@ async function main() {
!reporter ? path.join(__dirname, 'reporter.js') : reporter, !reporter ? path.join(__dirname, 'reporter.js') : reporter,
'-O', '-O',
`output=${tmpFilename}`, `output=${tmpFilename}`,
'-n',
'trace-warnings',
]; ];
const specPattern = 'test/build/**/*.spec.js'; const specPattern = 'test/build/**/*.spec.js';