github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refer to the upstream bug (#239)

Browse Source 
The issue #168 is a protocol inconsistency which happens only
in case of HTTPS error. This patch starts refering to the
upstream bug instead of puppeteer issue.

Closes #168.
This commit is contained in:
Andrey Lushnikov 2017-08-11 01:07:33 -07:00 committed by GitHub
parent 6347a049ba
commit b8dbd28b8c
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/NetworkManager.js
View File

@ -115,7 +115,7 @@ class NetworkManager extends EventEmitter {
_onLoadingFinished(event) {
let request = this._idToRequest.get(event.requestId);
// For certain requestIds we never receive requestWillBeSent event.
// @see https://github.com/GoogleChrome/puppeteer/issues/168
// @see https://crbug.com/750469
if (!request)
return;
request._completePromiseFulfill.call(null);
@ -129,7 +129,7 @@ class NetworkManager extends EventEmitter {
_onLoadingFailed(event) {
let request = this._idToRequest.get(event.requestId);
// For certain requestIds we never receive requestWillBeSent event.
// @see https://github.com/GoogleChrome/puppeteer/issues/168
// @see https://crbug.com/750469
if (!request)
return;
request._completePromiseFulfill.call(null);

2
test/test.js
View File

@ -524,7 +524,7 @@ describe('Page', function() {
}));
it('should fail when navigating to bad SSL', SX(async function() {
// Make sure that network events do not emit 'undefind'.
// @see https://github.com/GoogleChrome/puppeteer/issues/168
// @see https://crbug.com/750469
page.on('request', request => expect(request).toBeTruthy());
page.on('requestfinished', request => expect(request).toBeTruthy());
page.on('requestfailed', request => expect(request).toBeTruthy());