github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove NetworkServiceInProcess2 set by default (#12261)

Browse Source 
Puppeteer has relied on this flag for a [long time](https://github.com/puppeteer/puppeteer/pull/3738) but it looks like it is not required anymore and it might lead to crashes in the latest versions of Chrome for desktop. This CL removes the flag.

Issue #12257
This commit is contained in:
Alex Rudenko 2024-04-12 11:00:42 +02:00 committed by Alex Rudenko
parent 576b417216
commit ff4f70f4ae
3 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/browsers/test/src/chrome/launch.spec.ts
View File

@ -77,7 +77,6 @@ describe('Chrome', () => {
'--disable-renderer-backgrounding',
'--disable-sync',
'--enable-automation',
'--enable-features=NetworkServiceInProcess2',
'--export-tagged-pdf',
'--force-color-profile=srgb',
'--headless=new',

1
packages/browsers/test/src/chromium/launch.spec.ts
View File

@ -77,7 +77,6 @@ describe('Chromium', () => {
'--disable-renderer-backgrounding',
'--disable-sync',
'--enable-automation',
'--enable-features=NetworkServiceInProcess2',
'--export-tagged-pdf',
'--force-color-profile=srgb',
'--headless=new',

2
packages/puppeteer-core/src/node/ChromeLauncher.ts
View File

@ -192,7 +192,7 @@ export class ChromeLauncher extends ProductLauncher {
// Merge default enabled features with user-provided ones, if any.
const enabledFeatures = [
'NetworkServiceInProcess2',
// Add features to enable by default here.
...userEnabledFeatures,
].filter(feature => {
return feature !== '';