thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: update bidi tests for firefox (#10316)

Browse Source
This commit is contained in:
Alex Rudenko 2023-06-05 18:11:30 +02:00 committed by GitHub
parent 793a371837
commit ade6ad89f4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 41 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
test/TestExpectations.json
View File

@ -1283,24 +1283,6 @@
"parameters": ["firefox", "webDriverBiDi"],
"expectations": ["FAIL", "PASS"]
},
{
"testIdPattern": "[navigation.spec] navigation Page.goto should fail when navigating to bad SSL after redirects",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["firefox", "webDriverBiDi"],
"expectations": ["FAIL"]
},
{
"testIdPattern": "[navigation.spec] navigation Page.goto should fail when navigating to bad url",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["cdp", "firefox"],
"expectations": ["FAIL"]
},
{
"testIdPattern": "[navigation.spec] navigation Page.goto should fail when navigating to bad url",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["firefox", "webDriverBiDi"],
"expectations": ["FAIL"]
},
{
"testIdPattern": "[navigation.spec] navigation Page.goto should fail when server returns 204",
"platforms": ["darwin", "linux", "win32"],

31
test/src/mocha-utils.ts
View File

@ -250,6 +250,37 @@ export const mochaHooks = {
},
};
declare module 'expect' {
interface Matchers<R> {
atLeastOneToContain(expected: string[]): R;
}
}
expect.extend({
atLeastOneToContain: (actual: string, expected: string[]) => {
for (const test of expected) {
try {
expect(actual).toContain(test);
return {
pass: true,
message: () => {
return '';
},
};
} catch (err) {}
}
return {
pass: false,
message: () => {
return `"${actual}" didn't contain any of the strings ${JSON.stringify(
expected
)}`;
},
};
},
});
export const expectCookieEquals = (
cookies: Protocol.Network.Cookie[],
expectedCookies: Array<Partial<Protocol.Network.Cookie>>

17
test/src/navigation.spec.ts
View File

@ -142,17 +142,17 @@ describe('navigation', function () {
expect(response!.status()).toBe(200);
});
it('should fail when navigating to bad url', async () => {
const {page, isChrome} = getTestState();
const {page} = getTestState();
let error!: Error;
await page.goto('asdfasdf').catch(error_ => {
return (error = error_);
});
if (isChrome) {
expect(error.message).toContain('Cannot navigate to invalid URL');
} else {
expect(error.message).toContain('Invalid url');
}
expect(error.message).atLeastOneToContain([
'Cannot navigate to invalid URL', // Firefox WebDriver BiDi.
'invalid argument', // Others.
]);
});
const EXPECTED_SSL_CERT_MESSAGE_REGEX =
@ -200,7 +200,10 @@ describe('navigation', function () {
if (isChrome) {
expect(error.message).toMatch(EXPECTED_SSL_CERT_MESSAGE_REGEX);
} else {
expect(error.message).toContain('SSL_ERROR_UNKNOWN');
expect(error.message).atLeastOneToContain([
'MOZILLA_PKIX_ERROR_SELF_SIGNED_CERT', // Firefox WebDriver BiDi.
'SSL_ERROR_UNKNOWN ', // Others.
]);
}
});
it('should fail when main resources failed to load', async () => {