fix: page.goto
options type should be optional (#6038)
The TypeScript definition erroneously made `options` required. We can fix it by providing a default value, which means users calling the function will be able to leave it blank without TS complaining. Issues like this are a +1 to porting our tests to TypeScript in order to catch these on our own test suite, so that's something we should look into.
This commit is contained in:
parent
44402b75a0
commit
ce34c0a4ff
@ -7,7 +7,7 @@
|
||||
<b>Signature:</b>
|
||||
|
||||
```typescript
|
||||
goto(url: string, options: {
|
||||
goto(url: string, options?: {
|
||||
referer?: string;
|
||||
timeout?: number;
|
||||
waitUntil?: PuppeteerLifeCycleEvent | PuppeteerLifeCycleEvent[];
|
||||
|
@ -7,7 +7,7 @@
|
||||
<b>Signature:</b>
|
||||
|
||||
```typescript
|
||||
goto(url: string, options: WaitForOptions & {
|
||||
goto(url: string, options?: WaitForOptions & {
|
||||
referer?: string;
|
||||
}): Promise<HTTPResponse>;
|
||||
```
|
||||
|
@ -412,7 +412,7 @@ export class Frame {
|
||||
referer?: string;
|
||||
timeout?: number;
|
||||
waitUntil?: PuppeteerLifeCycleEvent | PuppeteerLifeCycleEvent[];
|
||||
}
|
||||
} = {}
|
||||
): Promise<HTTPResponse | null> {
|
||||
return await this._frameManager.navigateFrame(this, url, options);
|
||||
}
|
||||
|
@ -838,7 +838,7 @@ export class Page extends EventEmitter {
|
||||
|
||||
async goto(
|
||||
url: string,
|
||||
options: WaitForOptions & { referer?: string }
|
||||
options: WaitForOptions & { referer?: string } = {}
|
||||
): Promise<HTTPResponse> {
|
||||
return await this._frameManager.mainFrame().goto(url, options);
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user