thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: page.goto options type should be optional (#6038)

Browse Source 
The TypeScript definition erroneously made `options` required. We can
fix it by providing a default value, which means users calling the
function will be able to leave it blank without TS complaining.

Issues like this are a +1 to porting our tests to TypeScript in order to
catch these on our own test suite, so that's something we should look into.
This commit is contained in:
Jack Franklin 2020-06-18 12:44:46 +01:00 committed by GitHub
parent 44402b75a0
commit ce34c0a4ff
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
new-docs/puppeteer.frame.goto.md
View File

@ -7,7 +7,7 @@
<b>Signature:</b> <b>Signature:</b>
```typescript ```typescript
goto(url: string, options: { goto(url: string, options?: {
referer?: string; referer?: string;
timeout?: number; timeout?: number;
waitUntil?: PuppeteerLifeCycleEvent | PuppeteerLifeCycleEvent[]; waitUntil?: PuppeteerLifeCycleEvent | PuppeteerLifeCycleEvent[];

2
new-docs/puppeteer.page.goto.md
View File

@ -7,7 +7,7 @@
<b>Signature:</b> <b>Signature:</b>
```typescript ```typescript
goto(url: string, options: WaitForOptions & { goto(url: string, options?: WaitForOptions & {
referer?: string; referer?: string;
}): Promise<HTTPResponse>; }): Promise<HTTPResponse>;
``` ```

2
src/FrameManager.ts
View File

@ -412,7 +412,7 @@ export class Frame {
referer?: string; referer?: string;
timeout?: number; timeout?: number;
waitUntil?: PuppeteerLifeCycleEvent | PuppeteerLifeCycleEvent[]; waitUntil?: PuppeteerLifeCycleEvent | PuppeteerLifeCycleEvent[];
} } = {}
): Promise<HTTPResponse | null> { ): Promise<HTTPResponse | null> {
return await this._frameManager.navigateFrame(this, url, options); return await this._frameManager.navigateFrame(this, url, options);
} }

2
src/Page.ts
View File

@ -838,7 +838,7 @@ export class Page extends EventEmitter {
async goto( async goto(
url: string, url: string,
options: WaitForOptions & { referer?: string } options: WaitForOptions & { referer?: string } = {}
): Promise<HTTPResponse> { ): Promise<HTTPResponse> {
return await this._frameManager.mainFrame().goto(url, options); return await this._frameManager.mainFrame().goto(url, options);
} }