Commit Graph

11 Commits

Author SHA1 Message Date
Andrey Lushnikov
6a50888d34
fix(firefox): fix missing awaits in mouse.click ()
This applies the same fix we used on the Chrome-side and adds a test.

Fix 
2019-06-10 16:53:38 -07:00
Andrey Lushnikov
8a1c2495c0
test: add SVG clicking test ()
Someone had concerns that pptr's clicking doesn't work with SVG.

Make sure Puppeteer's clicking does.
2019-05-18 12:49:55 +03:00
Andrey Lushnikov
e3abb0aa32
feat(puppeteer): introduce puppeteer.errors and puppeteer.devices ()
These getters are introduced as a more convenient substitute for
a `require('puppeteer/Errors')` and
`require('puppeteer/DeviceDescriptors')`.

This way we can make cross-browser story nicer - a single require
of `puppeteer` or `puppeteer-firefox` fully defines Puppeteer
environment.
2019-04-19 15:33:06 -07:00
Andrey Lushnikov
a8ffdad76e
feat(chromium): roll Chromium to r650583 ()
This roll includes:
- https://crrev.com/650583 - DevTools: fix DOM.getContentQuads for a
  corner case

Fixes .
2019-04-13 00:28:58 -07:00
Andrey Lushnikov
145e8680b1
test: add failing test for clicking certain elements ()
References 
2019-04-13 00:10:48 -04:00
Andrey Lushnikov
5ee21d97e7
fix(page): intersect content quads with viewport ()
In certain cases inline element children might be positioned
outside of viewport.

In this case, we should intersect all content quads with viewport
before we pick one to click into.

Fixes .
2019-04-11 21:11:20 -04:00
Andrey Lushnikov
87a8d744e6
test: add a failing test that tries to click a fixed button in an iframe ()
References 
2019-03-06 18:46:40 -08:00
Andrey Lushnikov
ed984ac479
chore(firefox): kill original puppeteer-firefox tests ()
When we started working on Puppeteer-Firefox, we forked original
Puppeteer testsuite.

This patch concludes the effort to merge testsuites back together.

Fixes 
2019-02-21 13:10:15 -08:00
Andrey Lushnikov
14fb3e38db
chore(firefox): mark all Puppeteer tests that are failing on FF ()
This patch:
- introduces new testRunner methods `addTestDSL` and `addSuiteDSL`
  to add annotated test / suite.
- introduces new test/suite declaration methods: `it_fails_ffox` and
  `describe_fails_ffox`. These are equal to `it`/`describe` for chromium
  tests and to `xit`/`xdescribe` for firefox.
- marks all unsupported tests with `it_fails_ffox`
- adds a new command-line flag `'--firefox-status'` to `//test/test.js`.
  This flag dumps current amount of tests that are intentionally skipped
  for Firefox.

End goal: get rid of all `it_fails_ffox` and `describe_fails_ffox`
tests.

Drive-By: remove cookie tests  "afterEach" hook that was removing
cookies - it's not needed any more since every test is run in a
designated browser context.

References 
2019-02-05 22:32:41 -08:00
Andrey Lushnikov
fb710120e9
feat(page): use secondary world to drive clicks ()
References 
2019-01-22 23:24:14 -05:00
Andrey Lushnikov
25f4f26851
test: extract clicking tests () 2018-11-20 19:34:57 -08:00